Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(just): add fwupd firmware updates to justfile #130

Merged
merged 4 commits into from
Oct 5, 2023
Merged

feat(just): add fwupd firmware updates to justfile #130

merged 4 commits into from
Oct 5, 2023

Conversation

renner0e
Copy link
Contributor

@renner0e renner0e commented Oct 2, 2023 •
edited
Loading

Or is it maybe better to have it separate and call the shortcut like update-firmware?

@bsherman
Copy link
Contributor

bsherman commented Oct 4, 2023

Or is it maybe better to have it separate and call the shortcut like update-firmware?

I'd personally prefer a distinct update-firmware recipe, as I tend to update packages alot and firmware more tentatively.

bsherman
bsherman approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@bsherman bsherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bsherman bsherman enabled auto-merge October 5, 2023 15:14
@bsherman bsherman added this pull request to the merge queue Oct 5, 2023
Merged via the queue into ublue-os:main with commit c7c0841 Oct 5, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsherman bsherman bsherman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@renner0e @bsherman