Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #117 (flatpak update failing) #122

Merged
merged 2 commits into from
Sep 24, 2023
Merged

Fix #117 (flatpak update failing) #122

merged 2 commits into from
Sep 24, 2023

Conversation

ArtikusHG
Copy link
Contributor

This PR fixes issue #117, by making all the commands in the flatpak-system-update service run from ExecStart=, which prevents them from being automatically killed from time to time.

@ArtikusHG
Copy link
Contributor Author

It'd be really cool if we could merge this today so that it lands on tomorrow's image :)

Copy link
Contributor

@bsherman bsherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you please make the same changes to the flatpak-user-update.service file?

@ArtikusHG
Copy link
Contributor Author

Oh darn, I totally forgot about that one. One moment!

@ArtikusHG
Copy link
Contributor Author

@bsherman done

@ArtikusHG ArtikusHG requested a review from bsherman September 24, 2023 16:24
Copy link
Contributor

@bsherman bsherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Let's try it!

@bsherman bsherman enabled auto-merge September 24, 2023 16:28
@bsherman bsherman added this pull request to the merge queue Sep 24, 2023
Merged via the queue into ublue-os:main with commit 075ffd3 Sep 24, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants