-
-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(just): cleanup and standardization of just recipes #1003
Conversation
Shells: Configuration: Overall we probably have a lot of things that could be removed. We also should consider not in lining so much stuff. |
This would be great for shells! |
Currently since there have not been any verbs before on anything, i have left in aliases to the old recipe names so that you all can remove them when the time is right for it But i have updated everything (that made sense to update) to use the verbs we agreed on in the config repo. |
changes gnome-extensions to get-gnome-extensions changes gnome-vrr to toggle-gnome-vrr
As the containerfile flattens all the files into 1 just file, it is nice to see which part of the file originates from where on the system
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments. Overall looks solid
# if /etc/profile.d/brew.sh already exists, replace it with /usr/etc/profile.d/brew.sh | ||
if [ -f /etc/profile.d/brew.sh ]; then | ||
if [ -f /usr/etc/profile.d/brew.sh ]; then | ||
sudo cp /usr/etc/profile.d/brew.sh /etc/profile.d/brew.sh | ||
fi | ||
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get that we may want to do this, but instead of copying over, maybe a symlink might make more sense? This might be a change we need to do on our /etc/profile.d/brew.sh
If that's a file then the user has modified, if it's a symlink we won't have to update? Since this prompt doesn't go away, I would want to avoid overwriting user changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can change that, i think @bketelsen wrote that originally, might be a reason why it is not a symlink instead.
Will wait for them to reply before making that change though, but i am pretty sure a symlink will be fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no reason, symlink is a great idea. please proceed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll wrap up the brew symlink in another PR. LGTM.
Co-authored-by: Jorge O. Castro <[email protected]>
Drafting this so we can start a discussion.
Unlike the just reorg done in ublue-os/bazzite#765
Bluefin has way less just recipes so I would like to prod and hear what the reorg needs will be and if the just files should be split up in groups like we did in bazzite.
In bazzite we focused on merging together recipes that involved the same thing under the
configure-
andsetup-
verbs.configure
for things that already exist on the imagesetup
for anything that would require installation before configuring. (we also haveinstall-foo
for anything that just installs without any configuration or removal steps)shortcuts like
ujust benchmark
would stay as they are however i can merge all theujust zsh|fish|bash
intoujust configure-shell
with an alias namedujust shell
Other than this there does not seem to be anything else to do other than just some minor cleanup and change recipes to follow the standard we decided on in ublue-os/config#181