feat: added it87-extras for improved lm-sensors compatibility with some Gigabyte motherboards #261
Conversation
…me Gigabyte motherboards
|
Looks like the build workflows must be triggered before review anyway, updated pr to ready to review to allow maintainer to trigger |
|
@KyleGospo @HikariKnight @antheas Have you discussed the inclusion of this kmod. If we were to merge would it get installed in Bazzite? I think that's the critera for "extra" kmod additions at this point: "Does Bazzite plan to ship it?" |
|
I'd consider it, first time seeing this. |
|
@grandpares as is this doesn't actually build, your new build script needs to be added to the That will at least get it building for validation while the Bazzite team takes a look. |
|
Done, can you re-run build checks to make sure everything works @bsherman ? |
|
Okay, I think I know what's going on with the build failures. Purged some old builds that were messing with version control and renamed variables in the spec, seems to pick up the kernel version that akmods passes now. Hopefully this will fix it. |
|
@bsherman could you rerun the build checks to make sure everything builds now? |
Description
This recipe installs it87-extras, a packaged version of frankcrawford/it87 adding support for some Gigabyte motherboards. This package does not replace mainline it87 but installs a blacklist file for it as a dependency (contained in copr/grandapres/it87-extras/it87-extras-common).
Usecase
The primary purpose of the controllers this driver enables is PWM control of case fans, which is important for gaming systems. Therefore, this will be useful in Bazzite.
Issues
For most systems unsupported in the mainline, forcing controller ID when modprobing the driver and acpi_enforce_resources=lax are both necessary. Since the chip ID depends on the motherboard, and acpi_enforce_resources=lax is potentially destructive, neither should be set by default. A justfile that looks at the output of setup-sensors and then sets the necessary kargs is a possible solution, although I'm not sure where I could contribute one. However, users on unsupported systems should not experience any degradations compared to the mainline driver if these kargs are not set (their PWM controllers won't work in both cases).
Testing
I have tested that this module builds and installs from copr to akmod in Fedora 40 (mutable). Additionally, it builds from source, loads, and works as expected in aurora:stable. I wasn't sure if the akmods repo build actions are safe to run for testing, but if so, I can verify the image builds before merging. Currently, the copr repo is set to build from my fork of the module while I'm waiting for the upstream to review a PR containing the copr spec files.