Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add runner registration/delete mock #562

Merged
merged 9 commits into from
Nov 16, 2023

Conversation

BallyB
Copy link
Contributor

@BallyB BallyB commented Nov 15, 2023

We implemented the Register/Delete logic for the runner in the NGitLab Mock project. We needed these to unit test some use cases of runner registration.

We added the token registration properties in the project even though we are aware that it will be soon removed from the API : https://docs.gitlab.com/runner/register/#register-with-a-runner-registration-token-deprecated

@BallyB BallyB requested a review from a team as a code owner November 15, 2023 22:25
@BallyB BallyB requested review from louis-z and removed request for a team November 15, 2023 22:25
@BallyB BallyB marked this pull request as draft November 15, 2023 22:42
@BallyB BallyB marked this pull request as ready for review November 16, 2023 15:53
NGitLab.Mock/GitLabServer.cs Show resolved Hide resolved
NGitLab.Mock/Project.cs Outdated Show resolved Hide resolved
NGitLab.Mock/Clients/RunnerClient.cs Outdated Show resolved Hide resolved
NGitLab.Mock/Clients/RunnerClient.cs Outdated Show resolved Hide resolved
@meziantou meziantou merged commit 97a0852 into main Nov 16, 2023
6 checks passed
@meziantou meziantou deleted the add-runner-registration-delete-mock branch November 16, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants