Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace recent [Obsolete] additions with [EditorBrowsable] #559

Merged
merged 2 commits into from
Nov 13, 2023

Conversation

louis-z
Copy link
Member

@louis-z louis-z commented Nov 13, 2023

Recent changes to deprecate int project IDs in the API in favor of long IDs may result in several warnings in consuming projects. This is notably true because NGitLab.Models.Project.Id is still an int...

To reduce the noise for now, replace
[Obsolete("Use long or namespaced path string as projectId instead.")]
with
[EditorBrowsable(EditorBrowsableState.Never)]

Replace
[Obsolete("Use long or namespaced path string as projectId instead.")]
with
[EditorBrowsable(EditorBrowsableState.Never)]
@louis-z louis-z marked this pull request as ready for review November 13, 2023 14:31
@louis-z louis-z requested a review from a team as a code owner November 13, 2023 14:31
@louis-z louis-z requested review from Toa741 and removed request for a team November 13, 2023 14:31
@louis-z louis-z marked this pull request as draft November 13, 2023 14:38
@louis-z louis-z marked this pull request as ready for review November 13, 2023 14:43
@Toa741 Toa741 merged commit 1900a94 into main Nov 13, 2023
6 checks passed
@Toa741 Toa741 deleted the replace-recent-obsolete-additions-with-editorbrow branch November 13, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants