Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the default target_project_id when creating merge request #540

Merged
merged 2 commits into from
Oct 17, 2023

Conversation

PMExtra
Copy link
Contributor

@PMExtra PMExtra commented Oct 13, 2023

https://docs.gitlab.com/ee/api/merge_requests.html#create-mr

Attribute target_project_id is not required. GitLab will create the merge request for the current project by default. (It's already specified in the URL)

I removed the redundant codes to get ready for a new feature that supports the string type projectId for each client in NGitLab (includes MergeRequestClient, IssueClient, and so on).

I will open the pull request for the new feature as soon as possible after this pull request has merged.

@PMExtra PMExtra requested a review from a team as a code owner October 13, 2023 06:06
@PMExtra PMExtra requested review from Toa741 and removed request for a team October 13, 2023 06:06
@Toa741 Toa741 merged commit 09cdaae into ubisoft:main Oct 17, 2023
@PMExtra PMExtra deleted the feature/merge-request branch October 24, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants