Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate NGitLab from net461 to net462 + bump up LangVersion to 11.0 #534

Merged
merged 3 commits into from
Oct 4, 2023

Conversation

louis-z
Copy link
Member

@louis-z louis-z commented Oct 3, 2023

Plus

  • Use highest installed feature band and patch level that matches .NET SDK 7.0.100
  • Fix some analyzer rules

@louis-z louis-z requested a review from meziantou October 3, 2023 21:55
@louis-z louis-z marked this pull request as ready for review October 3, 2023 21:55
@louis-z louis-z requested a review from a team as a code owner October 3, 2023 21:55
@louis-z louis-z removed the request for review from meziantou October 3, 2023 22:03
@louis-z louis-z marked this pull request as draft October 3, 2023 22:05
@louis-z louis-z force-pushed the migrate-ngitlab-from-net461-to-net472-bump-up-lan branch 2 times, most recently from dda91a4 to ce1f512 Compare October 3, 2023 22:09
@louis-z louis-z force-pushed the migrate-ngitlab-from-net461-to-net472-bump-up-lan branch from ce1f512 to b15cd70 Compare October 3, 2023 22:09
@louis-z louis-z changed the title Migrate NGitLab from net461 to net472 + bump up LangVersion to 11.0 Migrate NGitLab from net461 to net462 + bump up LangVersion to 11.0 Oct 3, 2023
@louis-z louis-z requested a review from meziantou October 3, 2023 22:42
@louis-z louis-z marked this pull request as ready for review October 3, 2023 22:43
@meziantou meziantou merged commit 705e880 into main Oct 4, 2023
6 checks passed
@meziantou meziantou deleted the migrate-ngitlab-from-net461-to-net472-bump-up-lan branch October 4, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants