Replace record types with struct + interface

ubisoft · Nov 1, 2023 · bdcaa24 · bdcaa24
1 parent 11e2c1e
commit bdcaa24
Show file tree

Hide file tree

Showing 48 changed files with 113 additions and 89 deletions.
diff --git a/NGitLab.Mock/Clients/ClusterClient.cs b/NGitLab.Mock/Clients/ClusterClient.cs
@@ -11,7 +11,7 @@ internal sealed class ClusterClient : ClientBase, IClusterClient
         public ClusterClient(ClientContext context, ProjectId projectId)
             : base(context)
         {
-            _projectId = Server.AllProjects.FindProject(projectId.ValueAsUriParameter).Id;
+            _projectId = Server.AllProjects.FindProject(projectId.ValueAsUriParameter()).Id;
         }
 
         public IEnumerable<ClusterInfo> All => throw new NotImplementedException();

diff --git a/NGitLab.Mock/Clients/CommitClient.cs b/NGitLab.Mock/Clients/CommitClient.cs
@@ -12,7 +12,7 @@ internal sealed class CommitClient : ClientBase, ICommitClient
         public CommitClient(ClientContext context, ProjectId projectId)
             : base(context)
         {
-            _projectId = Server.AllProjects.FindProject(projectId.ValueAsUriParameter).Id;
+            _projectId = Server.AllProjects.FindProject(projectId.ValueAsUriParameter()).Id;
         }
 
         public Commit Create(CommitCreate commit)

diff --git a/NGitLab.Mock/Clients/CommitStatusClient.cs b/NGitLab.Mock/Clients/CommitStatusClient.cs
@@ -12,7 +12,7 @@ internal sealed class CommitStatusClient : ClientBase, ICommitStatusClient
         public CommitStatusClient(ClientContext context, ProjectId projectId)
             : base(context)
         {
-            _projectId = Server.AllProjects.FindProject(projectId.ValueAsUriParameter).Id;
+            _projectId = Server.AllProjects.FindProject(projectId.ValueAsUriParameter()).Id;
         }
 
         public CommitStatusCreate AddOrUpdate(CommitStatusCreate status)

diff --git a/NGitLab.Mock/Clients/EnvironmentClient.cs b/NGitLab.Mock/Clients/EnvironmentClient.cs
@@ -13,7 +13,7 @@ internal sealed class EnvironmentClient : ClientBase, IEnvironmentClient
         public EnvironmentClient(ClientContext context, ProjectId projectId)
             : base(context)
         {
-            _projectId = Server.AllProjects.FindProject(projectId.ValueAsUriParameter).Id;
+            _projectId = Server.AllProjects.FindProject(projectId.ValueAsUriParameter()).Id;
         }
 
         public IEnumerable<EnvironmentInfo> All => throw new NotImplementedException();

diff --git a/NGitLab.Mock/Clients/EventClient.cs b/NGitLab.Mock/Clients/EventClient.cs
@@ -14,11 +14,11 @@ public EventClient(ClientContext context)
         {
         }
 
-        public EventClient(ClientContext context, int? userId = null, ProjectId projectId = null)
+        public EventClient(ClientContext context, int? userId = null, ProjectId? projectId = null)
             : base(context)
         {
             _userId = userId;
-            _projectId = projectId is null ? null : Server.AllProjects.FindProject(projectId.ValueAsUriParameter).Id;
+            _projectId = projectId.HasValue ? Server.AllProjects.FindProject(projectId.ValueAsUriParameter()).Id : null;
         }
 
         IEnumerable<Models.Event> IEventClient.Get(EventQuery query)

diff --git a/NGitLab.Mock/Clients/GroupBadgeClient.cs b/NGitLab.Mock/Clients/GroupBadgeClient.cs
@@ -11,7 +11,7 @@ internal sealed class GroupBadgeClient : ClientBase, IGroupBadgeClient
         public GroupBadgeClient(ClientContext context, GroupId groupId)
             : base(context)
         {
-            _groupId = Server.AllGroups.FindGroup(groupId.ValueAsUriParameter).Id;
+            _groupId = Server.AllGroups.FindGroup(groupId.ValueAsUriParameter()).Id;
         }
 
         public Models.Badge this[int id]

diff --git a/NGitLab.Mock/Clients/GroupSearchClient.cs b/NGitLab.Mock/Clients/GroupSearchClient.cs
@@ -12,7 +12,7 @@ public GroupSearchClient(ClientContext context, GroupId groupId)
             : base(context)
         {
             _context = context;
-            _groupId = Server.AllGroups.FindGroup(groupId.ValueAsUriParameter).Id;
+            _groupId = Server.AllGroups.FindGroup(groupId.ValueAsUriParameter()).Id;
         }
 
         public GitLabCollectionResponse<SearchBlob> GetBlobsAsync(SearchQuery query)

diff --git a/NGitLab.Mock/Clients/GroupVariableClient.cs b/NGitLab.Mock/Clients/GroupVariableClient.cs
@@ -11,7 +11,7 @@ internal sealed class GroupVariableClient : ClientBase, IGroupVariableClient
         public GroupVariableClient(ClientContext context, GroupId groupId)
             : base(context)
         {
-            _groupId = Server.AllGroups.FindGroup(groupId.ValueAsUriParameter).Id;
+            _groupId = Server.AllGroups.FindGroup(groupId.ValueAsUriParameter()).Id;
         }
 
         public Variable this[string key] => throw new NotImplementedException();

diff --git a/NGitLab.Mock/Clients/JobClient.cs b/NGitLab.Mock/Clients/JobClient.cs
@@ -16,7 +16,7 @@ internal sealed class JobClient : ClientBase, IJobClient
         public JobClient(ClientContext context, ProjectId projectId)
             : base(context)
         {
-            _projectId = Server.AllProjects.FindProject(projectId.ValueAsUriParameter).Id;
+            _projectId = Server.AllProjects.FindProject(projectId.ValueAsUriParameter()).Id;
         }
 
         public Models.Job Get(int jobId)

diff --git a/NGitLab.Mock/Clients/MergeRequestClient.cs b/NGitLab.Mock/Clients/MergeRequestClient.cs
@@ -22,7 +22,7 @@ public MergeRequestClient(ClientContext context)
         public MergeRequestClient(ClientContext context, ProjectId projectId)
             : base(context)
         {
-            _projectId = Server.AllProjects.FindProject(projectId.ValueAsUriParameter).Id;
+            _projectId = Server.AllProjects.FindProject(projectId.ValueAsUriParameter()).Id;
         }
 
         private void AssertProjectId()

diff --git a/NGitLab.Mock/Clients/MilestoneClient.cs b/NGitLab.Mock/Clients/MilestoneClient.cs
@@ -12,13 +12,13 @@ internal sealed class MilestoneClient : ClientBase, IMilestoneClient
     {
         private readonly int _resourceId;
 
-        public MilestoneClient(ClientContext context, IdOrNamespacedPath id, MilestoneScope scope)
+        public MilestoneClient(ClientContext context, IidOrPathAddressable id, MilestoneScope scope)
             : base(context)
         {
             _resourceId = scope switch
             {
-                MilestoneScope.Groups => Server.AllGroups.FindGroup(id.ValueAsUriParameter).Id,
-                MilestoneScope.Projects => Server.AllProjects.FindProject(id.ValueAsUriParameter).Id,
+                MilestoneScope.Groups => Server.AllGroups.FindGroup(id.ValueAsUriParameter()).Id,
+                MilestoneScope.Projects => Server.AllProjects.FindProject(id.ValueAsUriParameter()).Id,
                 _ => throw new NotSupportedException($"{scope} milestone is not supported yet."),
             };
             Scope = scope;

diff --git a/NGitLab.Mock/Clients/PipelineClient.cs b/NGitLab.Mock/Clients/PipelineClient.cs
@@ -18,7 +18,7 @@ public PipelineClient(ClientContext context, IJobClient jobClient, ProjectId pro
             : base(context)
         {
             _jobClient = jobClient;
-            _projectId = Server.AllProjects.FindProject(projectId.ValueAsUriParameter).Id;
+            _projectId = Server.AllProjects.FindProject(projectId.ValueAsUriParameter()).Id;
         }
 
         public Models.Pipeline this[int id]

diff --git a/NGitLab.Mock/Clients/ProjectBadgeClient.cs b/NGitLab.Mock/Clients/ProjectBadgeClient.cs
@@ -12,7 +12,7 @@ internal sealed class ProjectBadgeClient : ClientBase, IProjectBadgeClient
         public ProjectBadgeClient(ClientContext context, ProjectId projectId)
             : base(context)
         {
-            _projectId = Server.AllProjects.FindProject(projectId.ValueAsUriParameter).Id;
+            _projectId = Server.AllProjects.FindProject(projectId.ValueAsUriParameter()).Id;
         }
 
         public Models.Badge this[int id]

diff --git a/NGitLab.Mock/Clients/ProjectIssueNoteClient.cs b/NGitLab.Mock/Clients/ProjectIssueNoteClient.cs
@@ -11,7 +11,7 @@ internal sealed class ProjectIssueNoteClient : ClientBase, IProjectIssueNoteClie
         public ProjectIssueNoteClient(ClientContext context, ProjectId projectId)
             : base(context)
         {
-            _projectId = Server.AllProjects.FindProject(projectId.ValueAsUriParameter).Id;
+            _projectId = Server.AllProjects.FindProject(projectId.ValueAsUriParameter()).Id;
         }
 
         public Models.ProjectIssueNote Create(ProjectIssueNoteCreate create)

diff --git a/NGitLab.Mock/Clients/ProjectLevelApprovalRulesClient.cs b/NGitLab.Mock/Clients/ProjectLevelApprovalRulesClient.cs
@@ -11,7 +11,7 @@ internal sealed class ProjectLevelApprovalRulesClient : ClientBase, IProjectLeve
         public ProjectLevelApprovalRulesClient(ClientContext context, ProjectId projectId)
             : base(context)
         {
-            _projectId = Server.AllProjects.FindProject(projectId.ValueAsUriParameter).Id;
+            _projectId = Server.AllProjects.FindProject(projectId.ValueAsUriParameter()).Id;
         }
 
         public List<ApprovalRule> GetProjectLevelApprovalRules()

diff --git a/NGitLab.Mock/Clients/ProjectSearchClient.cs b/NGitLab.Mock/Clients/ProjectSearchClient.cs
@@ -12,7 +12,7 @@ public ProjectSearchClient(ClientContext context, ProjectId projectId)
             : base(context)
         {
             _context = context;
-            _projectId = Server.AllProjects.FindProject(projectId.ValueAsUriParameter).Id;
+            _projectId = Server.AllProjects.FindProject(projectId.ValueAsUriParameter()).Id;
         }
 
         public GitLabCollectionResponse<SearchBlob> GetBlobsAsync(SearchQuery query)

diff --git a/NGitLab.Mock/Clients/ProjectVariableClient.cs b/NGitLab.Mock/Clients/ProjectVariableClient.cs
@@ -11,7 +11,7 @@ internal sealed class ProjectVariableClient : ClientBase, IProjectVariableClient
         public ProjectVariableClient(ClientContext context, ProjectId projectId)
             : base(context)
         {
-            _projectId = Server.AllProjects.FindProject(projectId.ValueAsUriParameter).Id;
+            _projectId = Server.AllProjects.FindProject(projectId.ValueAsUriParameter()).Id;
         }
 
         public Variable this[string key] => throw new NotImplementedException();

diff --git a/NGitLab.Mock/Clients/ProtectedBranchClient.cs b/NGitLab.Mock/Clients/ProtectedBranchClient.cs
@@ -11,7 +11,7 @@ internal sealed class ProtectedBranchClient : ClientBase, IProtectedBranchClient
         public ProtectedBranchClient(ClientContext context, ProjectId projectId)
             : base(context)
         {
-            _projectId = Server.AllProjects.FindProject(projectId.ValueAsUriParameter).Id;
+            _projectId = Server.AllProjects.FindProject(projectId.ValueAsUriParameter()).Id;
         }
 
         public Models.ProtectedBranch GetProtectedBranch(string branchName)

diff --git a/NGitLab.Mock/Clients/ReleaseClient.cs b/NGitLab.Mock/Clients/ReleaseClient.cs
@@ -16,7 +16,7 @@ internal sealed class ReleaseClient : ClientBase, IReleaseClient
         public ReleaseClient(ClientContext context, ProjectId projectId)
             : base(context)
         {
-            _projectId = Server.AllProjects.FindProject(projectId.ValueAsUriParameter).Id;
+            _projectId = Server.AllProjects.FindProject(projectId.ValueAsUriParameter()).Id;
         }
 
         public IEnumerable<Models.ReleaseInfo> All

diff --git a/NGitLab.Mock/Clients/RepositoryClient.cs b/NGitLab.Mock/Clients/RepositoryClient.cs
@@ -14,7 +14,7 @@ internal sealed class RepositoryClient : ClientBase, IRepositoryClient
         public RepositoryClient(ClientContext context, ProjectId projectId)
             : base(context)
         {
-            _projectId = Server.AllProjects.FindProject(projectId.ValueAsUriParameter).Id;
+            _projectId = Server.AllProjects.FindProject(projectId.ValueAsUriParameter()).Id;
         }
 
         public ITagClient Tags => new TagClient(Context, _projectId);

diff --git a/NGitLab.Mock/Clients/TriggerClient.cs b/NGitLab.Mock/Clients/TriggerClient.cs
@@ -11,7 +11,7 @@ internal sealed class TriggerClient : ClientBase, ITriggerClient
         public TriggerClient(ClientContext context, ProjectId projectId)
             : base(context)
         {
-            _projectId = Server.AllProjects.FindProject(projectId.ValueAsUriParameter).Id;
+            _projectId = Server.AllProjects.FindProject(projectId.ValueAsUriParameter()).Id;
         }
 
         public Trigger this[int id] => throw new NotImplementedException();

diff --git a/NGitLab.Mock/Clients/WikiClient.cs b/NGitLab.Mock/Clients/WikiClient.cs
@@ -11,7 +11,7 @@ internal sealed class WikiClient : ClientBase, IWikiClient
         public WikiClient(ClientContext context, ProjectId projectId)
             : base(context)
         {
-            _projectId = Server.AllProjects.FindProject(projectId.ValueAsUriParameter).Id;
+            _projectId = Server.AllProjects.FindProject(projectId.ValueAsUriParameter()).Id;
         }
 
         public WikiPage this[string slug] => throw new NotImplementedException();

diff --git a/NGitLab/GitLabClient.cs b/NGitLab/GitLabClient.cs
@@ -112,7 +112,7 @@ public IEventClient GetProjectEvents(int projectId)
             => GetProjectEvents((long)projectId);
 
         public IEventClient GetProjectEvents(ProjectId projectId)
-            => new EventClient(_api, $"projects/{projectId.ValueAsUriParameter}/events");
+            => new EventClient(_api, $"projects/{projectId.ValueAsUriParameter()}/events");
 
         public IRepositoryClient GetRepository(int projectId)
             => GetRepository((long)projectId);
@@ -238,12 +238,12 @@ public ISearchClient GetGroupSearchClient(int groupId)
             => GetGroupSearchClient((long)groupId);
 
         public ISearchClient GetGroupSearchClient(GroupId groupId)
-            => new SearchClient(_api, $"/groups/{groupId.ValueAsUriParameter}/search");
+            => new SearchClient(_api, $"/groups/{groupId.ValueAsUriParameter()}/search");
 
         public ISearchClient GetProjectSearchClient(int projectId)
             => GetProjectSearchClient((long)projectId);
 
         public ISearchClient GetProjectSearchClient(ProjectId projectId)
-            => new SearchClient(_api, $"/projects/{projectId.ValueAsUriParameter}/search");
+            => new SearchClient(_api, $"/projects/{projectId.ValueAsUriParameter()}/search");
     }
 }
diff --git a/NGitLab/Impl/ClusterClient.cs b/NGitLab/Impl/ClusterClient.cs
@@ -18,7 +18,7 @@ public ClusterClient(API api, int projectId)
         public ClusterClient(API api, ProjectId projectId)
         {
             _api = api;
-            _environmentsPath = $"{Project.Url}/{projectId.ValueAsUriParameter}/clusters";
+            _environmentsPath = $"{Project.Url}/{projectId.ValueAsUriParameter()}/clusters";
         }
 
         public IEnumerable<ClusterInfo> All => _api.Get().GetAll<ClusterInfo>(_environmentsPath);

diff --git a/NGitLab/Impl/CommitClient.cs b/NGitLab/Impl/CommitClient.cs
@@ -18,7 +18,7 @@ public CommitClient(API api, int projectId)
         public CommitClient(API api, ProjectId projectId)
         {
             _api = api;
-            var projectPath = $"{Project.Url}/{projectId.ValueAsUriParameter}";
+            var projectPath = $"{Project.Url}/{projectId.ValueAsUriParameter()}";
             _repoPath = $"{projectPath}/repository";
         }
 

diff --git a/NGitLab/Impl/CommitStatusClient.cs b/NGitLab/Impl/CommitStatusClient.cs
@@ -20,7 +20,7 @@ public CommitStatusClient(API api, ProjectId projectId)
         {
             _api = api;
 
-            var projectPath = $"{Project.Url}/{projectId.ValueAsUriParameter}";
+            var projectPath = $"{Project.Url}/{projectId.ValueAsUriParameter()}";
             _statusCreatePath = $"{projectPath}/statuses";
             _statusPath = $"{projectPath}/repository/commits";
         }

diff --git a/NGitLab/Impl/EnvironmentClient.cs b/NGitLab/Impl/EnvironmentClient.cs
@@ -21,7 +21,7 @@ public EnvironmentClient(API api, int projectId)
         public EnvironmentClient(API api, ProjectId projectId)
         {
             _api = api;
-            _environmentsPath = $"{Project.Url}/{projectId.ValueAsUriParameter}/environments";
+            _environmentsPath = $"{Project.Url}/{projectId.ValueAsUriParameter()}/environments";
         }
 
         public IEnumerable<EnvironmentInfo> All => _api.Get().GetAll<EnvironmentInfo>(_environmentsPath);

diff --git a/NGitLab/Impl/GroupBadgeClient.cs b/NGitLab/Impl/GroupBadgeClient.cs
@@ -5,7 +5,7 @@ namespace NGitLab.Impl
     internal sealed class GroupBadgeClient : BadgeClient, IGroupBadgeClient
     {
         public GroupBadgeClient(API api, GroupId groupId)
-            : base(api, $"{Group.Url}/{groupId.ValueAsUriParameter}")
+            : base(api, $"{Group.Url}/{groupId.ValueAsUriParameter()}")
         {
         }
     }

diff --git a/NGitLab/Impl/GroupVariableClient.cs b/NGitLab/Impl/GroupVariableClient.cs
@@ -5,7 +5,7 @@ namespace NGitLab.Impl
     internal sealed class GroupVariableClient : VariableClient, IGroupVariableClient
     {
         public GroupVariableClient(API api, GroupId groupId)
-            : base(api, $"{Group.Url}/{groupId.ValueAsUriParameter}")
+            : base(api, $"{Group.Url}/{groupId.ValueAsUriParameter()}")
         {
         }
     }

diff --git a/NGitLab/Impl/JobClient.cs b/NGitLab/Impl/JobClient.cs
@@ -22,7 +22,7 @@ public JobClient(API api, int projectId)
         public JobClient(API api, ProjectId projectId)
         {
             _api = api;
-            _jobsPath = $"{Project.Url}/{projectId.ValueAsUriParameter}/jobs";
+            _jobsPath = $"{Project.Url}/{projectId.ValueAsUriParameter()}/jobs";
         }
 
         public IEnumerable<Job> GetJobs(JobScopeMask scope)

diff --git a/NGitLab/Impl/MergeRequestClient.cs b/NGitLab/Impl/MergeRequestClient.cs
@@ -25,7 +25,7 @@ public MergeRequestClient(API api, int projectId)
         public MergeRequestClient(API api, ProjectId projectId)
         {
             _api = api;
-            _projectPath = $"{Project.Url}/{projectId.ValueAsUriParameter}";
+            _projectPath = $"{Project.Url}/{projectId.ValueAsUriParameter()}";
         }
 
         public MergeRequestClient(API api)

diff --git a/NGitLab/Impl/MilestoneClient.cs b/NGitLab/Impl/MilestoneClient.cs
@@ -12,16 +12,16 @@ public class MilestoneClient : IMilestoneClient
         private readonly API _api;
         private readonly string _milestonePath;
 
-        internal MilestoneClient(API api, MilestoneScope scope, IdOrNamespacedPath id)
+        internal MilestoneClient(API api, MilestoneScope scope, IidOrPathAddressable id)
         {
             _api = api;
-            _milestonePath = $"/{scope.ToString().ToLowerInvariant()}/{id.ValueAsUriParameter}/milestones";
+            _milestonePath = $"/{scope.ToString().ToLowerInvariant()}/{id.ValueAsUriParameter()}/milestones";
             Scope = scope;
         }
 
         [Obsolete("Use GitLabClient.GetMilestone() or GitLabClient.GetGroupMilestone() instead.")]
         public MilestoneClient(API api, int projectId)
-            : this(api, MilestoneScope.Projects, projectId)
+            : this(api, MilestoneScope.Projects, (ProjectId)projectId)
         {
         }
 

diff --git a/NGitLab/Impl/PipelineClient.cs b/NGitLab/Impl/PipelineClient.cs
@@ -24,7 +24,7 @@ public PipelineClient(API api, int projectId)
         public PipelineClient(API api, ProjectId projectId)
         {
             _api = api;
-            _projectPath = $"{Project.Url}/{projectId.ValueAsUriParameter}";
+            _projectPath = $"{Project.Url}/{projectId.ValueAsUriParameter()}";
             _pipelinesPath = $"{_projectPath}/pipelines";
         }
 

diff --git a/NGitLab/Impl/ProjectBadgeClient.cs b/NGitLab/Impl/ProjectBadgeClient.cs
@@ -7,7 +7,7 @@ namespace NGitLab.Impl
     internal sealed class ProjectBadgeClient : BadgeClient, IProjectBadgeClient
     {
         public ProjectBadgeClient(API api, ProjectId projectId)
-            : base(api, $"{Project.Url}/{projectId.ValueAsUriParameter}")
+            : base(api, $"{Project.Url}/{projectId.ValueAsUriParameter()}")
         {
         }
 

diff --git a/NGitLab/Impl/ProjectIssueNoteClient.cs b/NGitLab/Impl/ProjectIssueNoteClient.cs
@@ -21,7 +21,7 @@ public ProjectIssueNoteClient(API api, int projectId)
         public ProjectIssueNoteClient(API api, ProjectId projectId)
         {
             _api = api;
-            _projectId = projectId.ValueAsUriParameter;
+            _projectId = projectId.ValueAsUriParameter();
         }
 
         public IEnumerable<ProjectIssueNote> ForIssue(int issueId)

diff --git a/NGitLab/Impl/ProjectLevelApprovalRulesClient.cs b/NGitLab/Impl/ProjectLevelApprovalRulesClient.cs
@@ -19,7 +19,7 @@ public ProjectLevelApprovalRulesClient(API api, int projectId)
         public ProjectLevelApprovalRulesClient(API api, ProjectId projectId)
         {
             _api = api;
-            _approvalRulesUrl = $"{Project.Url}/{projectId.ValueAsUriParameter}/approval_rules";
+            _approvalRulesUrl = $"{Project.Url}/{projectId.ValueAsUriParameter()}/approval_rules";
         }
 
         public List<ApprovalRule> GetProjectLevelApprovalRules()

diff --git a/NGitLab/Impl/ProjectVariableClient.cs b/NGitLab/Impl/ProjectVariableClient.cs
@@ -5,7 +5,7 @@ namespace NGitLab.Impl
     internal sealed class ProjectVariableClient : VariableClient, IProjectVariableClient
     {
         public ProjectVariableClient(API api, ProjectId projectId)
-            : base(api, $"{Project.Url}/{projectId.ValueAsUriParameter}")
+            : base(api, $"{Project.Url}/{projectId.ValueAsUriParameter()}")
         {
         }
     }

diff --git a/NGitLab/Impl/ProtectedBranchClient.cs b/NGitLab/Impl/ProtectedBranchClient.cs
@@ -12,7 +12,7 @@ internal sealed class ProtectedBranchClient : IProtectedBranchClient
         public ProtectedBranchClient(API api, ProjectId projectId)
         {
             _api = api;
-            _protectedBranchesUrl = $"{Project.Url}/{projectId.ValueAsUriParameter}/protected_branches";
+            _protectedBranchesUrl = $"{Project.Url}/{projectId.ValueAsUriParameter()}/protected_branches";
         }
 
         public ProtectedBranch ProtectBranch(BranchProtect branchProtect)

diff --git a/NGitLab/Impl/ReleaseClient.cs b/NGitLab/Impl/ReleaseClient.cs
@@ -17,7 +17,7 @@ internal sealed class ReleaseClient : IReleaseClient
         public ReleaseClient(API api, ProjectId projectId)
         {
             _api = api;
-            var projectPath = $"{Project.Url}/{projectId.ValueAsUriParameter}";
+            var projectPath = $"{Project.Url}/{projectId.ValueAsUriParameter()}";
             _releasesPath = $"{projectPath}/releases";
         }
 

diff --git a/NGitLab/Impl/RepositoryClient.cs b/NGitLab/Impl/RepositoryClient.cs
@@ -23,7 +23,7 @@ public RepositoryClient(API api, int projectId)
         public RepositoryClient(API api, ProjectId projectId)
         {
             _api = api;
-            _projectPath = $"{Project.Url}/{projectId.ValueAsUriParameter}";
+            _projectPath = $"{Project.Url}/{projectId.ValueAsUriParameter()}";
             _repoPath = $"{_projectPath}/repository";
         }