Fix naming convention

ubisoft · Oct 25, 2024 · 86e5028 · 86e5028
1 parent 25de5fc
commit 86e5028
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 5 deletions.
diff --git a/NGitLab.Mock/Clients/PipelineScheduleClient.cs b/NGitLab.Mock/Clients/PipelineScheduleClient.cs
@@ -47,7 +47,7 @@ public IEnumerable<PipelineScheduleBasic> All
     public GitLabCollectionResponse<PipelineScheduleBasic> GetAllAsync()
         => GitLabCollectionResponse.Create(All);
 
-    public GitLabCollectionResponse<PipelineBasic> GetAllSchedulePipelines(int id)
+    public GitLabCollectionResponse<PipelineBasic> GetAllSchedulePipelinesAsync(int id)
     {
         using (Context.BeginOperationScope())
         {

diff --git a/NGitLab/IPipelineScheduleClient.cs b/NGitLab/IPipelineScheduleClient.cs
@@ -38,7 +38,6 @@ public interface IPipelineScheduleClient
     /// Get all pipelines triggered by a pipeline schedule in a project.
     /// </summary>
     /// <param name="id">Schedule Id</param>
-    /// <param name="cancellationToken"></param>
     /// <returns></returns>
-    GitLabCollectionResponse<PipelineBasic> GetAllSchedulePipelines(int id);
+    GitLabCollectionResponse<PipelineBasic> GetAllSchedulePipelinesAsync(int id);
 }
diff --git a/NGitLab/Impl/PipelineScheduleClient.cs b/NGitLab/Impl/PipelineScheduleClient.cs
@@ -27,7 +27,7 @@ public PipelineScheduleClient(API api, ProjectId projectId)
     public GitLabCollectionResponse<PipelineScheduleBasic> GetAllAsync()
         => _api.Get().GetAllAsync<PipelineScheduleBasic>(_schedulesPath);
 
-    public GitLabCollectionResponse<PipelineBasic> GetAllSchedulePipelines(int id)
+    public GitLabCollectionResponse<PipelineBasic> GetAllSchedulePipelinesAsync(int id)
         => _api.Get().GetAllAsync<PipelineBasic>($"{_schedulesPath}/{id.ToStringInvariant()}/pipelines");
 
     public Task<PipelineSchedule> GetByIdAsync(int id, CancellationToken cancellationToken = default)

diff --git a/NGitLab/PublicAPI.Unshipped.txt b/NGitLab/PublicAPI.Unshipped.txt
@@ -1048,7 +1048,7 @@ NGitLab.IPipelineClient.UpdateMetadataAsync(int pipelineId, NGitLab.Models.Pipel
 NGitLab.IPipelineScheduleClient
 NGitLab.IPipelineScheduleClient.All.get -> System.Collections.Generic.IEnumerable<NGitLab.Models.PipelineScheduleBasic>
 NGitLab.IPipelineScheduleClient.GetAllAsync() -> NGitLab.GitLabCollectionResponse<NGitLab.Models.PipelineScheduleBasic>
-NGitLab.IPipelineScheduleClient.GetAllSchedulePipelines(int id) -> NGitLab.GitLabCollectionResponse<NGitLab.Models.PipelineBasic>
+NGitLab.IPipelineScheduleClient.GetAllSchedulePipelinesAsync(int id) -> NGitLab.GitLabCollectionResponse<NGitLab.Models.PipelineBasic>
 NGitLab.IPipelineScheduleClient.GetByIdAsync(int id, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) -> System.Threading.Tasks.Task<NGitLab.Models.PipelineSchedule>
 NGitLab.IPipelineScheduleClient.this[int id].get -> NGitLab.Models.PipelineSchedule
 NGitLab.IProjectBadgeClient