Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update empty-string-checker.ts #84

Closed
wants to merge 1 commit into from
Closed

Conversation

rndquu
Copy link
Member

@rndquu rndquu commented Nov 21, 2024

Check this failing empty string check CI run which fails with the following error:

Error: An error occurred: Resource not accessible by integration - https://docs.github.com/rest/checks/runs#create-a-check-run

The pull_request trigger runs in the context of a forked repository. In order to use the checks.create() API the workflow must use the checks: write permission. But forked instances can only have the read permission.

This PR removes the checks.create() call so that forked instances were not failing. This way the CI is still failing and shows meaningful warnings.

QA: https://github.com/rndquu/ts-template/actions/runs/11953756844/job/33322322490?pr=6

@rndquu rndquu marked this pull request as ready for review November 21, 2024 13:07
@ubiquity-os-deployer
Copy link

@rndquu rndquu requested a review from 0x4007 November 21, 2024 13:07
Copy link
Member

@0x4007 0x4007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a big downgrade from showing in the files changed view. Surely there is another workaround that preserves this capability?

@rndquu rndquu closed this Nov 21, 2024
@rndquu
Copy link
Member Author

rndquu commented Nov 21, 2024

This is a big downgrade from showing in the files changed view. Surely there is another workaround that preserves this capability?

#85

@rndquu rndquu deleted the rndquu-patch-1 branch November 21, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants