Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: workflow permissions #25

Merged
merged 5 commits into from
Mar 6, 2024
Merged

fix: workflow permissions #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
860695d
chore: moved knip configuration
gentlementlegen Mar 6, 2024
79c9b1c
chore: workflow dispatch for knip
gentlementlegen Mar 6, 2024
0ac9d65
chore: changed action target to pull_request_target
gentlementlegen Mar 6, 2024
93194db
Merge remote-tracking branch 'ubi/development' into fix/permissions
gentlementlegen Mar 6, 2024
85f20d4
ci(cspell): fix
0x4007 Mar 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion knip.ts → .github/knip.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,4 @@ const config: KnipConfig = {
ignoreDependencies: [],
};

export default config;
export default config;
2 changes: 1 addition & 1 deletion .github/workflows/jest-testing.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: Run Jest testing suite
on:
workflow_dispatch:
pull_request:
pull_request_target:
types: [ opened, synchronize ]

env:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/knip.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: Knip

on:
pull_request:
pull_request_target:
workflow_dispatch:

permissions: write-all
Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@
"format:lint": "eslint --fix .",
"format:prettier": "prettier --write .",
"format:cspell": "cspell **/*",
"knip": "knip",
"knip-ci": "knip --no-exit-code --reporter json",
"knip": "knip --config .github/knip.ts",
"knip-ci": "knip --no-exit-code --reporter json --config .github/knip.ts",
"prepare": "husky install",
"test": "jest --setupFiles dotenv/config --coverage",
"cy:open": "cypress open",
Expand Down
1 change: 1 addition & 0 deletions tests/__mocks__/db.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
// cSpell:disable
import { factory, primaryKey } from "@mswjs/data";

/**
Expand Down