Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge develop into main #133

Merged
merged 152 commits into from
Sep 30, 2024
Merged

Merge develop into main #133

merged 152 commits into from
Sep 30, 2024

Conversation

gentlementlegen
Copy link
Member

EresDev and others added 30 commits August 9, 2024 01:12
@EresDev
feat: evaluate code reviews comments with openai
52bd951
@EresDev
fix: give relevance 1 to PR comment with no-code
b6dc127
@EresDev
fix: remove PR fixed relevance to use openai
9786ada
@EresDev
test: change issue to test PR review comments
a03d14a 
Update test issue to one that has PR code review comments
@EresDev
fix: give default relevance 1 to pull spec in test
4af0362
@EresDev
Merge branch 'development' of https://github.com/ubiquibot/conversati…
db161e9 
…on-rewards into development
@EresDev
refactor: add return type to method
7d6ebbc
@EresDev
refactor: remove redundant type
b223454
@EresDev
refactor: move types to correct file
3d32bc9
@EresDev
fix: add missing http mocks for target issue 5 & its pr 12
3d114d1
@EresDev
refactor: improve how diff_hunk property is added
ee199db
@EresDev
fix: use correct prompt for review comments
251f0ce
@EresDev
refactor: improve combining relevances for different types
32d98ff
@EresDev
refactor: remove redundant mocks
ce2d0b2
@EresDev
fix: increase openai max token limit 3x
7090b65 
128 token handling roughly 10 code review commetns
@EresDev
fix: get code review evaulation without issue specs
f56d997
@EresDev
refactor: rename diff_hunk to diffHunk
99089b2
@EresDev
refactor: rename missing diff_hunk to diffHunk
df15cb3
@EresDev
Revert "fix: get code review evaulation without issue specs"
2e45590 
This reverts commit f56d997.
@EresDev
fix: send all PR comments to openai for evaluation
e379989
@EresDev
fix: update ai prompt to cover all PR comment types
4549c80
@EresDev
Merge branch 'development' of https://github.com/ubiquibot/conversati…
464703d 
…on-rewards into development
@EresDev
test: update expected output with openai relevance
041edf9
@EresDev
test: update expected output using openai relevance
ee86b77
@EresDev
refactor: rename reviewComments to prComments
ee9dd9e
@rndquu
fix: use issue.node_id for permit nonces
1d2ad4d
@obeys
refactor(verbosity): better handling for verbosity
4e19255
@rndquu
build: use permit generation v1.4.3
3ddf768
@obeys
fix: fixed decimal issues with evaluation
1e30cd2
@obeys
fix: edited the mock results to match new calculation module
a0d007c
gentlementlegen and others added 23 commits September 24, 2024 10:41
@gentlementlegen
chore: fixed tests
fb4385f
@gentlementlegen
chore: space between price
5c385d6
@gentlementlegen
chore: space between price
4b78d58
@gentlementlegen
chore: space between price
03dfbf7
@gentlementlegen
chore: fixed tests
4e429c2
@gentlementlegen
chore: added header metadata
94ed8f8
@gentlementlegen
chore: added header metadata
bd32e73
@gentlementlegen
chore: added header metadata
565ee48
@gentlementlegen
chore: fixed tests
9c8df84
@gentlementlegen
chore: fixed tests
cf7a938
@gentlementlegen
chore: fixed tests
2fd2aac
@gentlementlegen
chore(WIP): scoring changes
3fbfee2
@0x4007
Merge pull request #126 from gentlementlegen/fix/compress-html
04fba45 
feat: compressing html output
@gentlementlegen
chore: added comment strip
26f5a1a
@gentlementlegen
Merge branch 'refs/heads/feat/text-strip' into feat/element-score
933f128
@gentlementlegen
Merge branch 'development' into feat/element-score
eb6bcbb 
# Conflicts:
#	tests/__mocks__/results/github-comment-results.json
#	tests/__mocks__/results/output-reward-split.html
#	tests/__mocks__/results/output.html
#	tests/__mocks__/results/reward-split.json
@gentlementlegen
chore: added regex to result
1fdbd24
@gentlementlegen
chore: fixed tests
5576148
@gentlementlegen
fix: no message is posted on skip
512519d
@0x4007
Merge pull request #130 from gentlementlegen/fix/remove-skip-message
db7f3f5
@gentlementlegen
chore: changed defaults
41c68d8
@gentlementlegen
fix: removed regex from configuration
19e70a4
@0x4007
Merge pull request #121 from gentlementlegen/feat/element-score
139d2a2
@0x4007
Copy link
Member

0x4007 commented Sep 30, 2024 •
edited
Loading

We still have to fix the config in @ubiquity. Perhaps you know how to do it quickly.

@gentlementlegen
Copy link
Member Author

@0x4007 I supposedly fixed it, what is missing?

@gentlementlegen gentlementlegen marked this pull request as ready for review September 30, 2024 16:35
@0x4007
Copy link
Member

0x4007 commented Sep 30, 2024 •
edited
Loading

https://github.com/ubiquity-os-marketplace/conversation-rewards/actions/runs/11108830072/job/30862713555#step:7:61

It didn't generate rewards that run

@gentlementlegen
Copy link
Member Author

gentlementlegen commented Sep 30, 2024 •
edited
Loading

@0x4007 Should be fixed when merging this, I suppose.

We do not handle different branches for the configuration, so the dev branch is fine but not the main (using older code).

@gentlementlegen gentlementlegen merged commit 337be98 into main Sep 30, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x4007 0x4007 Awaiting requested review from 0x4007

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gentlementlegen @0x4007 @EresDev @rndquu @obeys