Allow to wiremock API responses instead of using sandbox #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks for the commits! I won't have time to full review until after Thanksgiving week, but then this will be on my radar to get reviewed and merged. |
|
Sorry about this, busy week has lead to still not getting to this, we'll look to get at this soon. |
|
+1 |
tyvsmith
approved these changes
Aug 16, 2018
|
Getting back to this after a while away from this project. Change looks good but needs to be rebased. |
|
Rebased ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We extensively use Rides API and have about 30 integration tests with various API interactions. When using sandbox our build took about 8 minutes to finish, so we decided to mock Rides API with WireMock. Now the build takes less than 3 minutes ;)
Details
Instead of setting Environment we added a baseUrl property which is used to build endpointHost if present.