Use type arguments of generic methods to check for generic type parameter's nullability #1065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next-generics-test #1065 +/- ##
=====================================================
Coverage ? 87.70%
Complexity ? 2227
=====================================================
Files ? 85
Lines ? 7297
Branches ? 1441
=====================================================
Hits ? 6400
Misses ? 456
Partials ? 441 ☔ View full report in Codecov by Sentry. |
msridhar
reviewed
Nov 4, 2024
| @@ -616,8 +616,48 @@ public static void compareGenericTypeParameterNullabilityForCall( | |||
| // all remaining actual arguments in the next loop. | |||
| n = n - 1; | |||
| } | |||
|
|
|||
| List<Symbol.VarSymbol> newFormalParameters = new ArrayList<>(); | |||
There was a problem hiding this comment.
I'm pretty sure this logic is not right. It's looking at upper bounds, which are not relevant for this check. Just like what we did before for generic methods, we need to look at the type arguments at the call site and apply the substitution to the types of the formal parameters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made NullAway to check generic type parameter's nullability using the type arguments passed at the call site (generic methods).
The relevant unit test is
void genericMethodAndVoidType()in thejspecify/GenericMethodTests.javafile.