-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add json support to Pointer #180
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #180 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 23 23
Lines 394 402 +8
=========================================
+ Hits 394 402 +8 ☔ View full report in Codecov by Sentry. |
}) | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could a test case be added for the Unmarshal case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure what are you asking, do you mean line 112?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I get it. you mean Unmarshal error case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! This change looks good to me! Left a comment about adding a test case for Unmarshal error.
Maybe the typo in PR and first commit could be fixed Porinter => Pointer Code and documentation are OK. |
can this pr be merged with squash? I fixed pr title but i don't want to use force push to fix commit message |
I will let maintainers reply. But, I don't think force push would be a problem here. Maybe you can wait for the review to be done. But each repository has its rules/norms/habits |
Hey @trim21 and @ccoVeille, sorry for the delay. We always merge the PR with a "squash and merge". I've updated the message to change the word to pointer. |
Before opening your pull request, please make sure that you've:
make test
); and finally,make lint
).close #178