Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add json support to Pointer #180

Merged
merged 3 commits into from
Aug 6, 2024
Merged

add json support to Pointer #180

merged 3 commits into from
Aug 6, 2024

Conversation

trim21
Copy link
Contributor

@trim21 trim21 commented Jul 17, 2024

Before opening your pull request, please make sure that you've:

  • updated the changelog if the change is user-facing;
  • added tests to cover your changes;
  • run the test suite locally (make test); and finally,
  • run the linters locally (make lint).

close #178

@CLAassistant
Copy link

CLAassistant commented Jul 17, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (6187ac0) to head (6303253).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #180   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           23        23           
  Lines          394       402    +8     
=========================================
+ Hits           394       402    +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

})
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could a test case be added for the Unmarshal case?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure what are you asking, do you mean line 112?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I get it. you mean Unmarshal error case

Copy link
Contributor

@r-hang r-hang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! This change looks good to me! Left a comment about adding a test case for Unmarshal error.

@ccoVeille
Copy link

Maybe the typo in PR and first commit could be fixed

Porinter => Pointer

Code and documentation are OK.

@trim21 trim21 changed the title add json support to Porinter add json support to Pointer Jul 30, 2024
@trim21 trim21 requested a review from r-hang July 30, 2024 14:56
@trim21
Copy link
Contributor Author

trim21 commented Jul 30, 2024

Maybe the typo in PR and first commit could be fixed

Porinter => Pointer

Code and documentation are OK.

can this pr be merged with squash? I fixed pr title but i don't want to use force push to fix commit message

@ccoVeille
Copy link

I will let maintainers reply.

But, I don't think force push would be a problem here.

Maybe you can wait for the review to be done. But each repository has its rules/norms/habits

@r-hang
Copy link
Contributor

r-hang commented Aug 6, 2024

Hey @trim21 and @ccoVeille, sorry for the delay. We always merge the PR with a "squash and merge". I've updated the message to change the word to pointer.

@r-hang r-hang merged commit 8768b7d into uber-go:master Aug 6, 2024
8 checks passed
@trim21 trim21 deleted the json-pointer branch August 6, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support json encode decode for Pointer
4 participants