Make build faster:

* manual tilt launch
* tiltignore
* use buildkit with cache
* Add makefile check gofmt
* add github action to check gofmt

.github/workflows/build.yaml

@@ -12,6 +12,9 @@ jobs:
     - uses: actions/setup-go@v3
       with:
         go-version: '1.17.8'
+    - name: check-gofmt
+      run: make checkfmt
+      shell: bash
     - name: Lint
       run: make vet
       shell: bash

.tiltignore

@@ -0,0 +1,8 @@
+capm.yaml
+LICENSE
+Makefile
+README.md
+osc-secret.yaml
+CONTRIBUTING.md
+example/*.yaml
+docs/*.md

Dockerfile

@@ -7,7 +7,9 @@ COPY go.mod go.mod
 COPY go.sum go.sum
 # cache deps before building and copying source so that we don't need to re-download as much
 # and so that source changes don't invalidate our downloaded layer
-RUN go mod download
+RUN  --mount=type=cache,target=/root/.local/share/golang \
+     --mount=type=cache,target=/go/pkg/mod \
+     go mod download
 
 # Copy the go source
 COPY main.go main.go
@@ -16,7 +18,13 @@ COPY controllers/ controllers/
 COPY cloud/ cloud/
 COPY util/ util/
 # Build
-RUN CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -a -o manager main.go
+ARG LDFLAGS
+ARG ARCH=amd64
+
+RUN --mount=type=cache,target=/root/.cache/go-build \
+    --mount=type=cache,target=/go/pkg/mod \
+    --mount=type=cache,target=/root/.local/share/golang \
+    CGO_ENABLED=0 GOOS=linux GOARCH=${ARCH} go build -ldflags "${LDFLAGS} -extldflags '-static'"  -o manager .
 
 # Use distroless as minimal base image to package the manager binary
 # Refer to https://github.com/GoogleContainerTools/distroless for more details

Makefile

@@ -59,6 +59,14 @@ fmt: ## Run go fmt against code.
 vet: ## Run go vet against code.
 	go vet ./...
 
+.PHONY: gofmt
+gofmt: ## Run gofmt
+	find . -name "*.go" | grep -v "\/vendor\/" | xargs gofmt -s -w
+
+.PHONY: checkfmt
+checkfmt: ## check gofmt
+	./check-gofmt
+
 .PHONY: unit-test
 unit-test: 
 	go test -v -coverprofile=covers.out  ./...

Tiltfile

@@ -1,7 +1,10 @@
 
+trigger_mode(TRIGGER_MODE_MANUAL)
+
 docker_build(os.getenv('CONTROLLER_IMAGE', ''), '.')
 
 
 allow_k8s_contexts(os.getenv('K8S_CONTEXT', 'phandalin'))
 
+
 k8s_yaml('capm.yaml')

check-gofmt

@@ -0,0 +1,13 @@
+#!/bin/bash
+
+set -euo pipefail
+set -x
+echo "Check with gofmt"
+
+change=$(find . -name "*.go" | grep -v "\/vendor\/" | xargs gofmt -s -d 2>&1)
+if [[ -n ${change} ]]; then
+  echo "${change}"
+  echo "Please run make gofmt"
+  exit 1
+fi
+echo "Format is good"

cloud/scope/clients.go

@@ -4,8 +4,8 @@ import (
 	"context"
 	"os"
 
-	osc "github.com/outscale/osc-sdk-go/v2"
 	"errors"
+	osc "github.com/outscale/osc-sdk-go/v2"
 )
 
 // OscClient contains input client to use outscale api

cloud/scope/cluster.go

@@ -3,12 +3,12 @@ package scope
 import (
 	"context"
 
+	"errors"
+	"fmt"
 	"github.com/go-logr/logr"
 	infrastructurev1beta1 "github.com/outscale-dev/cluster-api-provider-outscale.git/api/v1beta1"
 	"github.com/outscale-dev/cluster-api-provider-outscale.git/cloud"
 	osc "github.com/outscale/osc-sdk-go/v2"
-	"errors"
-        "fmt"
 	"k8s.io/klog/v2/klogr"
 	clusterv1 "sigs.k8s.io/cluster-api/api/v1beta1"
 	"sigs.k8s.io/cluster-api/util/conditions"
@@ -60,7 +60,7 @@ func NewClusterScope(params ClusterScopeParams) (*ClusterScope, error) {
 	helper, err := patch.NewHelper(params.OscCluster, params.Client)
 	if err != nil {
 		return nil, fmt.Errorf("%w failed to init patch helper", err)
-	}	
+	}
 
 	return &ClusterScope{
 		Logger:      params.Logger,

cloud/tag/tag.go

@@ -2,10 +2,11 @@ package tag
 
 import (
 	"context"
-	"fmt"
-	osc "github.com/outscale/osc-sdk-go/v2"
 	"errors"
+	"fmt"
 	"regexp"
+
+	osc "github.com/outscale/osc-sdk-go/v2"
 )
 
 // AddTag add a tag to a resource