Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline Readme #31

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Streamline Readme #31

wants to merge 3 commits into from

Conversation

snadi
Copy link
Contributor

@snadi snadi commented Nov 10, 2022

I also have the following additional comments/questions:

  • You created the wiki page in your IntelliMerge fork, right? Can you include a proper title/description to indicate that these are your changes? and perhaps link to that in the ReadMe.

  • The RefMerge release links to january.. you updated for the revision after that, can you link to new version?

  • Which version/commit of RefactoringMiner did you use?

"It will be under build/distributions." --> what is it?

I am confused about Step 3. Is this creating new databases to reproduce our results from scratch or is this populating the DBs with our existing evaluation data for examination?

"Use the refactoring analysis dump found here
to populate the original_analysis database." --> but this dump is from 2018. We re-ran it to collect the data.

What is "refactoringAwareMerging_dataset" ??

I don't understand what "IntelliMerge" replication section is in the ReadMe. Are these prereqs step I need to do before running? Or is this info on how we reproduced intellMerge? If the latter, perhaps this can be a separate doc/wiki page that is linked from here as extra info later in the ReadMe? so as not to disrupt the flow of how to run things? Because the next section already says that everything is in the repo. I changed the ReadMe to streamline things but I'm not sure if my changes are correct. I moved that section to the end but i'm still not sure where it belongs.

"
4. Wait for IntelliJ to build the cloned project, then close it." --> close the project or what? If you close the project, how will the rest of the evaluation run? And what will run? Should you have opened the RefMerge or this repo in Intellij first? (like is there a missing step at the beginning here?)

@snadi snadi requested a review from max-ellis November 10, 2022 08:48
@snadi
Copy link
Contributor Author

snadi commented Nov 10, 2022

Note that there is an IntelliMerge-1.0.7-modified.jar in the root directory.. I believe it should only be the version in the lib folder correcT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant