Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are further comments/questions I have:
For running:
It is not clear what Step 4 is and which configuration files to edit. So I need to edit a config file whenever I need to run it?. Perhaps also point that this can be automated and link to the evaluation repo? "This works when..." not clear what this means here. In general, this step is confusing. Please clarify
what should the user see after Step 5? and where will they see it?
For adding new refactoring part:
please add a list of supported refactorings somewhere in the repo.
For example,
Move Method
will come beforeRename Variable
and afterMove Class
. ==> example is not clear.. aren't variables "lower" in the hierarchy? Or are there special cases?For step 3.2, where should they add the related simplification logic in the code? The step also says just "logic" ... which logic?
Similar for step 3.3, where should this be added... Also, what does "combined" mean here?
Step 5: wasn't all that conflict logic done in the previous step? What is the "logic matrix".. Perhaps first, you should have an overview of how the code is structured (very briefly) and the terms you use.. You loosely use "logic" and "matrix" but someone not familiar with the details will not get this. Also the steps there aren't clear.. What is "dispatcher and receiver hashmaps." ?
Step 6.1. "for rename method is
RefactoringFactory
andRenameRefactoring
." -- why is it RefactoringFactor? Why not just "RenameFactory".. Also, what is a refactoring processor? You mean one of IntelliJ's existing processors?Step 7 "In most cases, the refactoring process to replay the refactoring will be the same." --> same as what