Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zizmor to CI #250

Merged
merged 2 commits into from
Dec 22, 2024
Merged

Add zizmor to CI #250

merged 2 commits into from
Dec 22, 2024

Conversation

masklinn
Copy link
Contributor

Although the actions are pretty simple, it probably can't hurt to fix them up using better knowledge than mine.

Fixes #249

- Can't switch release actions to trusted publishing, see ua-parser#224.
- Remove git credentials persistence everywhere.
- Fix "unsafe" template expansion in release-builtins. It should not
  be accessible to any untrusted third party as it's only on
  `workflow_dispatch` and `schedule`, but it can't hurt.

Fixes ua-parser#249
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@masklinn masklinn merged commit 9f170aa into ua-parser:master Dec 22, 2024
26 checks passed
@masklinn masklinn deleted the zizmor branch December 22, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add zizmor to test flows
1 participant