run mypy even if ruff fails #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because all the checks are performed in the same job and github actions will stop at the first step failure within a job, if one of the ruff checks (formatting or checking) fails then mypy does not run at all, which is undesirable. Turns out the steps have an implicit `if success()` if no [status check function][check] (`success`, `failure`, `always`, `cancelled`) is used to guard the step. Thus by gating on `always` and possibly explicitly checking the conclusion of specific checks it becomes possible to run `mypy` even though `ruff check` failed, but not run it if *installing* mypy failed. [check]: https://docs.github.com/en/actions/learn-github-actions/expressions#status-check-functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because all the checks are performed in the same job and github actions will stop at the first step failure within a job, if one of the ruff checks (formatting or checking) fails then mypy does not run at all, which is undesirable.
Turns out the steps have an implicit
if success()if no status check function (success,failure,always,cancelled) is used to guard the step.Thus by gating on
alwaysand possibly explicitly checking the conclusion of specific checks it becomes possible to runmypyeven thoughruff checkfailed, but not run it if installing mypy failed.