Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable pypy311 #178

Merged
merged 1 commit into from
Feb 3, 2024
Merged

Disable pypy311 #178

merged 1 commit into from
Feb 3, 2024

Conversation

masklinn
Copy link
Contributor

@masklinn masklinn commented Feb 3, 2024

Despite the suite succeeding as noted in
e9483d8, github sucks so it still marks a PR / commit as failing if non-required tests fail (red cross on the commit and "Some checks were not successful" on the PR), which sucks.

Not to mention pypy311 does not exist yet, let alone being provided by setup-python, so it can never succeed.

Therefore remove it.

Apparently I fucked up something when I tried to merge #175 so that didn't work, oops

@masklinn masklinn enabled auto-merge (rebase) February 3, 2024 16:21
Despite the suite succeeding as noted in
e9483d8, github sucks so it still
marks a PR / commit as failing if non-required tests fail (red cross
on the commit and "Some checks were not successful" on the PR), which
sucks.

Not to mention pypy311 does not exist yet, let alone being provided by
setup-python, so it can never succeed.

Therefore remove it.
@masklinn masklinn merged commit 6ad6f04 into ua-parser:master Feb 3, 2024
29 checks passed
@masklinn masklinn deleted the disable-pypy311-ci branch February 3, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant