Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new optional dependency sets #177

Closed
wants to merge 1 commit into from
Closed

Add new optional dependency sets #177

wants to merge 1 commit into from

Conversation

masklinn
Copy link
Contributor

@masklinn masklinn commented Feb 3, 2024

Fixes #172 (except not for the reasons explained over there)

@masklinn
Copy link
Contributor Author

masklinn commented Oct 8, 2024

  • black and flake8 have been dropped (for ruff)
  • mypy hasn't, but it's not really useful as an optional dependency
  • both re2 and regex were added as optional dependencies when the corresponding parser was implemented

Thus I don't think this PR has much relevance at this point, especially without the ability to use them for a just-deps install (pypa/pip#11440) as indicated by the comment on #172

@masklinn masklinn closed this Oct 8, 2024
@masklinn masklinn deleted the dependency-sets branch October 8, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve optional dependencies
1 participant
@masklinn