feat: add Huawei HarmonyOS parser #604
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbarthon
reviewed
Dec 5, 2024
regexes.yaml
Outdated
| os_replacement: 'Harmony' | ||
| os_v1_replacement: '$1' | ||
| os_v2_replacement: '$2' | ||
| os_v3_replacement: '$3' |
There was a problem hiding this comment.
os_v1 / v2 / v3 replacements are not needed, as it will take the capture groups above in order
lbarthon
reviewed
Dec 5, 2024
regexes.yaml
Outdated
| @@ -1915,6 +1915,13 @@ os_parsers: | |||
| os_v2_replacement: '$2' | |||
| os_v3_replacement: '$3' | |||
|
|
|||
| # Huawei HarmonyOS | |||
| - regex: 'HarmonyOS\s?(\d*).?(\d*).?(\d*)' | |||
There was a problem hiding this comment.
please use \d+, as otherwise this might mess up the capture groups - also, are those actually optional? if not, let's enforce a format such as \d+\.\d+\.\d+
There was a problem hiding this comment.
Some Harmony OS User-Agent strings may not explicitly include the version number. Here are two examples:
e.g.
- with version
Mozilla/5.0 (Linux; Android 12; LIO-AN00 Build/HUAWEILIO-AN00; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/97.0.4692.98 Mobile Safari/537.36 T7/13.76 BDOS/1.0 (HarmonyOS 3.0.0) SP-engine/3.17.0 baiduboxapp/13.76.0.10 (Baidu; P1 12) NABar/1.0
- without version
Mozilla/5.0 (Linux; Android 12; HarmonyOS; CET-AL00; HMSCore 6.14.0.322) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/114.0.5735.196 HuaweiBrowser/15.0.9.300 Mobile Safari/537.36
There was a problem hiding this comment.
How about this regex: (HarmonyOS)[\s;]+(\d+|)\.?(\d+|)\.?(\d+|)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Huawei HarmonyOS parser