Add Iframely unfurling robot #589
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbarthon
reviewed
Sep 17, 2024
regexes.yaml
Outdated
| @@ -1926,6 +1929,12 @@ device_parsers: | |||
| brand_replacement: 'Spider' | |||
| model_replacement: 'Desktop' | |||
|
|
|||
| # Iframely robot (https://iframely.com/docs/about) | |||
| - regex: 'Iframely/' | |||
There was a problem hiding this comment.
Can't you add this to the big Spiders regex here
Line 5917 in 3380632
There was a problem hiding this comment.
@lbarthon I wasn't sure if that was the still the standard way to add new bots/thingies, but yes I think I can adjust it to use that and rebase my changes on the current master soon. Thanks.
There was a problem hiding this comment.
I think I've correctly shifted to that method and the tests still pass locally.
It is used by Atlassian (and others) for fetching content for link unfurling: https://iframely.com/docs/about
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add detection as a bot for the Iframely unfurling robot is used by Atlassian and others for fetching links to unfurl. See https://iframely.com/docs/about