Update UA for Ladybird Browser (previously SerenityOS Browser) #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MacDue
force-pushed
the
ladybird_browser
branch
2 times, most recently
from
f9602f5 to
bd5d1da
Compare
linusg
reviewed
May 9, 2023
Let the history books show I was on the side of 'Browser': #18735 |
|
@commenthol rebased 🙂 |
lbarthon
approved these changes
Feb 21, 2024
|
FWIW the regex used here has been outdated for at least 6 months by now and will no longer match: SerenityOS/serenity@4ead33d |
|
Checked before, noticed that it was still Ladybird/1.0 but missed that one, will file a fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The browser has always been called 'Ladybird' outside SerenityOS, and now is even called Ladybird in Serenity (see SerenityOS/serenity@15211cd).
The format of the user agent has also changed since it was first added here. Given the nature of the Ladybird project it's highly unlikely there's any users of the old version, so that UA probably does not need to be preserved.
cc @linusg