Rename 'Mac OS X' to 'macOS' #535
Conversation
Since 2016 it's officially named macOS: https://en.wikipedia.org/wiki/MacOS This is a separate change similar to the PR which has been open for a while and which has merge conflicts: ua-parser#482 Also my version comes without gratuitous whitespace changes :D
| os_v1_replacement: '$1' | ||
| os_v2_replacement: '$2' | ||
| os_v3_replacement: '$3' | ||
| # Leopard | ||
| - regex: ' (Dar)(win)/(9).(\d+).{0,100}\((?:i386|x86_64|Power Macintosh)\)' | ||
| os_replacement: 'Mac OS X' | ||
| os_replacement: 'macOS' |
There was a problem hiding this comment.
macOS was officially branded with the release of macOS 10.12 Sierra. Leopard and older are "Mac OS X" or "OSX".
Do we want, need to re-label these names as well?
There was a problem hiding this comment.
Just let me know, if you want, I can address this!
|
PR is a duplicate of #482 |
Yes indeed, I noted this in my original message. But that PR got stuck and has a merge conflict and I wanted to get this issue fixed, so I decided to make a new, similar one. |
|
Hi @commenthol , can you look at this PR please? |
|
I don't think this is a good idea. Such a change would break any code that depends on the specific string |
Since 2016 it's officially named macOS:
https://en.wikipedia.org/wiki/MacOS
This is a separate change similar to the PR which has been open for a while and which has merge conflicts:
#482
Also my version comes with less gratuitous whitespace changes :D