Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more spiders #394

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add more spiders #394

wants to merge 1 commit into from

Conversation

hsluoyz
Copy link

@hsluoyz hsluoyz commented Mar 24, 2019

No description provided.

@elsigh
Copy link
Contributor

elsigh commented Apr 10, 2019

Do you have any supporting docs for the addition of "googleapps" as a spider?

@hsluoyz
Copy link
Author

hsluoyz commented Apr 11, 2019

See here: https://rehmann.co/blog/googleapps-script-bot/

@kingo55
Copy link

kingo55 commented May 4, 2019

Should you add a unit test for this UA?

I've noticed the spiders catchall does not always work as expected. Case in point:

  1. The regex already searches for "bot"
  2. The example UA provided has the word "bot" in it

If it's not being matched, then there's likely a problem with the catchall here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs testcase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hsluoyz @elsigh @kingo55 @commenthol