Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag and template default values: unspecified != empty #31

Merged
merged 2 commits into from
Feb 25, 2024
Merged

Conversation

hugelgupf
Copy link
Member

No description provided.

Copy link

codecov bot commented Feb 25, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 77.63%. Comparing base (565b87e) to head (8fe1bd0).

Files Patch % Lines
uimage/mkuimage/cmd.go 75.00% 1 Missing and 1 partial ⚠️
uimage/mkuimage/uflags.go 95.65% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #31      +/-   ##
==========================================
+ Coverage   77.43%   77.63%   +0.20%     
==========================================
  Files          23       23              
  Lines        1440     1449       +9     
==========================================
+ Hits         1115     1125      +10     
  Misses        227      227              
+ Partials       98       97       -1     
Flag Coverage Δ
ubuntu-latest-unit 77.63% <92.30%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…y come from template or base main file

Signed-off-by: Chris Koch <[email protected]>
@hugelgupf hugelgupf merged commit 11a3bcc into main Feb 25, 2024
10 checks passed
@hugelgupf hugelgupf deleted the defaults branch February 25, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant