Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds support for fastify #63

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

sebacruz
Copy link

@sebacruz sebacruz commented Jun 3, 2021

I am trying to add support for fastify but i'm just starting to use this package. Are there any other files that I need to modify?

@tzellman
Copy link
Owner

tzellman commented Jun 7, 2021

@sebacruz Thanks for the PR! I'll pull it down and take a look - we may need to make express and fastify peer dependencies in order to not require apps to be dependent on both.

Copy link
Owner

@tzellman tzellman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The project currently uses the LTS version of node (defined in the .nvmrc file). We'll have to update the PR to use that version so that the lock file doesn't use version 2.

@tzellman
Copy link
Owner

tzellman commented Jun 7, 2021

The jsonapiRequestHolder that is added to the request object is only available as an extension to the Express.Request interface.. I am pretty confident we will need to make some more changes to the middleware and exception-filter in order to get this to work properly with fastify.

Additionally, we will want to orchestrate the test suite so that both express and fastify are tested against. I'll need to dig in a little to see how this would make the most sense to do. 👍

@sebacruz
Copy link
Author

sebacruz commented Jun 8, 2021

@tzellman thank you for you review.

I've already been working on changes that you suggested, can you confirm that they are ok?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants