Improved MemoryLeakTest

typhoon-php · Feb 9, 2024 · 39e3411 · 39e3411
1 parent 1e6e064
commit 39e3411
Showing 1 changed file with 27 additions and 28 deletions.
diff --git a/tests/memory/MemoryLeakTest.php b/tests/memory/MemoryLeakTest.php
@@ -44,22 +44,30 @@ public static function setUpBeforeClass(): void
         }
 
         self::$phpParser = (new ParserFactory())->createForHostVersion();
+        self::cleanUpParser();
     }
 
     private static function cleanUpParser(): void
     {
         self::$phpParser->parse('');
     }
 
-    public function testTyphoonReflectorClassExistsIsNotLeaking(): void
+    private static function assertMemoryIsConstant(\Closure $action): void
     {
-        foreach (self::CLASSES as $class) {
-            $memory = memory_get_usage();
+        $memory = memory_get_usage();
+
+        $action();
+        self::cleanUpParser();
 
-            TyphoonReflector::build(phpParser: self::$phpParser)->classExists($class);
-            self::cleanUpParser();
+        self::assertLessThanOrEqual(500, memory_get_usage() - $memory);
+    }
 
-            self::assertLessThanOrEqual($memory, memory_get_usage());
+    public function testTyphoonReflectorClassExistsIsNotLeaking(): void
+    {
+        foreach (self::CLASSES as $class) {
+            self::assertMemoryIsConstant(static function () use ($class): void {
+                TyphoonReflector::build(phpParser: self::$phpParser)->classExists($class);
+            });
         }
     }
 
@@ -70,48 +78,39 @@ public function testTyphoonReflectorReflectIsNotLeaking(): void
         self::cleanUpParser();
 
         foreach (self::CLASSES as $class) {
-            $memory = memory_get_usage();
-
-            TyphoonReflector::build(phpParser: self::$phpParser)->reflectClass($class);
-            self::cleanUpParser();
-
-            self::assertLessThanOrEqual($memory, memory_get_usage());
+            self::assertMemoryIsConstant(static function () use ($class): void {
+                TyphoonReflector::build(phpParser: self::$phpParser)->reflectClass($class);
+            });
         }
     }
 
     public function testReflectionSessionClassExistsIsNotLeaking(): void
     {
-        $session =    TyphoonReflector::build(phpParser: self::$phpParser)->startSession();
+        $session = TyphoonReflector::build(phpParser: self::$phpParser)->startSession();
         $session->classExists(Type\NamedObjectType::class);
         $session->flush();
         self::cleanUpParser();
 
         foreach (self::CLASSES as $class) {
-            $memory = memory_get_usage();
-
-            $session->classExists($class);
-            $session->flush();
-            self::cleanUpParser();
-
-            self::assertLessThanOrEqual($memory, memory_get_usage());
+            self::assertMemoryIsConstant(static function () use ($session, $class): void {
+                $session->classExists($class);
+                $session->flush();
+            });
         }
     }
 
     public function testReflectionSessionReflectIsNotLeaking(): void
     {
-        $session =    TyphoonReflector::build(phpParser: self::$phpParser)->startSession();
+        $session = TyphoonReflector::build(phpParser: self::$phpParser)->startSession();
         $session->reflectClass(Type\NamedObjectType::class);
         $session->flush();
         self::cleanUpParser();
 
         foreach (self::CLASSES as $class) {
-            $memory = memory_get_usage();
-
-            $session->reflectClass($class);
-            $session->flush();
-            self::cleanUpParser();
-
-            self::assertLessThanOrEqual($memory, memory_get_usage());
+            self::assertMemoryIsConstant(static function () use ($session, $class): void {
+                $session->reflectClass($class);
+                $session->flush();
+            });
         }
     }
 }