役員の役職・名前が複数行にまたがるケースを正しくパースできるようにする #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yokonao
commented
Jul 15, 2024
Comment on lines
+249
to
+253
| posAndNames, three := getMultipleExecutiveNamesAndPositions(p) | ||
| if len(posAndNames) > 0 { | ||
| evs.Name = posAndNames[0].Name | ||
| evs.Position = posAndNames[0].Position | ||
| } |
There was a problem hiding this comment.
この PR 時点では最初の結果のみ利用する
後続のPRで、残りの結果を最終結果に反映する予定
Code Metrics Report
Details | | main (8bdbbde) | #110 (4376269) | +/- |
|---------------------|----------------|----------------|-------|
- | Coverage | 6.2% | 6.2% | -0.1% |
| Files | 12 | 12 | 0 |
| Lines | 609 | 614 | +5 |
| Covered | 38 | 38 | 0 |
- | Code to Test Ratio | 1:0.0 | 1:0.0 | -0.0 |
| Code | 7863 | 7876 | +13 |
| Test | 198 | 198 | 0 |
- | Test Execution Time | 25s | 27s | +2s |Code coverage of files in pull request scope (0.0% → 0.0%)
Reported by octocov |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
役員の役職や名前が複数行にまたがっている場合に、結果が意図しないものになることが多かったのでパースロジックを改善しました。