Skip to content

Commit

Permalink
csl: Remove dependency on maven.twttr.com
Browse files Browse the repository at this point in the history
Problem

maven.twttr.com is a bummer

Solution

Stop depending on it, now that we've published to maven central!

RB_ID=878967
  • Loading branch information
mosesn authored and jenkins committed Oct 10, 2016
1 parent 96cdde7 commit 7c863d0
Show file tree
Hide file tree
Showing 4 changed files with 22 additions and 17 deletions.
21 changes: 14 additions & 7 deletions CHANGES
Original file line number Diff line number Diff line change
Expand Up @@ -15,20 +15,26 @@ No Changes
1.22.0
------

New Features
~~~~~~~~~~~~

* No longer need to add an additional resolver that points to maven.twttr.com.
``RB_ID=878967``

Runtime Behavior Changes
~~~~~~~~~~~~~~~~~~~~~~~~

* twitter-server: ShutdownHandler and AbortHandler accept only POST
requests and ignore non-POST requests. ``RB_ID=848212``
* ShutdownHandler and AbortHandler accept only POST requests and ignore
non-POST requests. ``RB_ID=848212``

1.21.0
------

Bug Fixes
~~~~~~~~~

* twitter-server: escape user input that is rendered in HTML, and make
bin/travisci publish finagle-toggle. ``RB_ID=848579``
* Escape user input that is rendered in HTML, and make bin/travisci publish
finagle-toggle. ``RB_ID=848579``

New Features
~~~~~~~~~~~~
Expand All @@ -43,9 +49,10 @@ New Features
Breaking API Changes
~~~~~~~~~~~~~~~~~~~~

* twitter-server: Removed AdminHttpServer#mkRoutex method. This method
was created during the migration away from direct usage of netty
http types and is now redundant. ``RB_ID=835083``
* Removed AdminHttpServer#mkRoutex method. This method was created during the
migration away from direct usage of netty http types and is now
redundant. ``RB_ID=835083``

* Builds are now only for Java 8 and Scala 2.11. See the
`blog post <https://finagle.github.io/blog/2016/04/20/scala-210-and-java7/>`_
for details. ``RB_ID=828898``
Expand Down
11 changes: 5 additions & 6 deletions doc/src/sphinx/Features.rst
Original file line number Diff line number Diff line change
Expand Up @@ -84,12 +84,11 @@ handler on the admin interface.
Metrics
-------

Note: In order to enable usage of the Metrics library, you must have
the finagle-stats jar on your classpath. `finagle-stats` depends on
libraries which can be found in the
`https://maven.twttr.com <https://maven.twttr.com>`_ repository. There
are instructions on the :doc:`quickstart <index>` for adding it in
maven or sbt.
Note: In order to enable usage of the Metrics library, you must have the
finagle-stats jar on your classpath. Before version 6.39.0, `finagle-stats`
depended on libraries which can be found in the `https://maven.twttr.com
<https://maven.twttr.com>`_ repository. There are instructions on the
:doc:`quickstart <index>` for adding it in maven or sbt.

The `statsReceiver` field of `TwitterServer` defines a sink for
metrics. With it you can update counters and stats (histograms) or
Expand Down
6 changes: 3 additions & 3 deletions doc/src/sphinx/index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,9 @@ or, with sbt:
libraryDependencies += "com.twitter" %% "twitter-server" % "|release|"
NB: You only need to add the ``maven.twttr.com`` repository if you want
to use libraries in Twitter `common`, which are only published to
``maven.twttr.com``. For example, ``finagle-stats``, which adds
NB: You only need to add the ``maven.twttr.com`` repository if you want to use
libraries in Twitter `common`, which are only published to ``maven.twttr.com``,
and you're using 1.23.0 or earlier. For example, ``finagle-stats``, which adds
:doc:`Metrics <Features>`, requires a twitter `common` library.

First we’ll need to import a few things into our namespace.
Expand Down
1 change: 0 additions & 1 deletion project/Build.scala
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ object TwitterServer extends Build {
"junit" % "junit" % "4.10" % "test",
"org.mockito" % "mockito-all" % "1.9.5" % "test"
),
resolvers += "twitter-repo" at "https://maven.twttr.com",

ScoverageSbtPlugin.ScoverageKeys.coverageHighlighting := true,

Expand Down

0 comments on commit 7c863d0

Please sign in to comment.