Skip to content

Commit

Permalink
twitter-server: Fix Line Break Tag in Client Endpoints
Browse files Browse the repository at this point in the history
Problem / Solution

The `Endpoints` section of the `Clients` page is
rendering incorrect HTML line breaks. Let's fix them up.

JIRA Issues: CSL-9007

Differential Revision: https://phabricator.twitter.biz/D391907
  • Loading branch information
ryanoneill authored and jenkins committed Oct 30, 2019
1 parent 344a5ab commit 4463e9d
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 5 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ Unreleased

* Add initial support for JDK 11 compatibility. ``PHAB_ID=D365075``

* The endpoints section of the clients page has been fixed
to no longer render an incorrect html line break tag. ``PHAB_ID=D391907``

19.10.0
-------
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,12 @@ private[server] object EndpointRegistryView {
<ul>
${(for ((dtab, observations) <- dtabEntries) yield {
s"""
<li>Dtab</br>
<li>Dtab<br/>
<div>${renderDtab(dtab)}</div>
<div>Resolved Endpoints</br>
<div>Resolved Endpoints<br/>
<ul>
${(for ((path, addr) <- observations) yield {
s"""<li>Path: ${path}</br>""" +
s"""<li>Path: ${path}<br/>""" +
(addr match {
case Addr.Bound(endpoints, metadata) =>
val weight: Double = metadata.get(AddrWeightKey) match {
Expand All @@ -41,8 +41,8 @@ private[server] object EndpointRegistryView {
-1.0
case None => 1.0
}
s"""Weight: ${weight}</br>
Endpoints:</br>
s"""Weight: ${weight}<br/>
Endpoints:<br/>
<ul>
${(for (endpoint <- endpoints) yield {
s"""<li>${endpoint}</li>"""
Expand Down

0 comments on commit 4463e9d

Please sign in to comment.