twitter-server/slf4j-log4j12: Mark deprecated

Problem Log4j 1.x was EOL in 2015. It is time to drop support for the logging framework from TwitterServer. Solution Mark the BUILD targets and the LoggingHandler as deprecated with the intention to remove. Users are encouraged to use Logback as a replacement. Differential Revision: https://phabricator.twitter.biz/D812006
twitter · Jan 12, 2022 · 2e213f7 · 2e213f7
1 parent cbc7383
commit 2e213f7
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 4 deletions.
diff --git a/slf4j-log4j12/README.md b/slf4j-log4j12/README.md
@@ -1,5 +1,5 @@
-TwitterServer `slf4j-log4j12`
-============================
+[DEPRECATED] TwitterServer `slf4j-log4j12`
+==========================================
 
 This library provides a wrapper over the [`slf4j-log4j12`](https://www.slf4j.org/manual.html#swapping) logging 
 implementation for use in `TwitterServer` along with the appropriate [SLF4J bridges](https://www.slf4j.org/legacy.html)

diff --git a/slf4j-log4j12/src/main/resources/BUILD b/slf4j-log4j12/src/main/resources/BUILD
@@ -4,5 +4,8 @@ resources(
         "!BUILD*",
         "**/*",
     ],
-    tags = ["bazel-compatible"],
+    tags = [
+        "bazel-compatible",
+        "deprecated",  # Users are encouraged to use twitter-server/logback-classic instead
+    ],
 )
diff --git a/slf4j-log4j12/src/main/scala/BUILD b/slf4j-log4j12/src/main/scala/BUILD
@@ -9,6 +9,7 @@ scala_library(
     scope = "forced",  # Exposes a service-loaded class.
     tags = [
         "bazel-compatible",
+        "deprecated",  # Users are encouraged to use twitter-server/logback-classic instead
         "logging_impl_check_whitelisted_target",
     ],
     dependencies = [

diff --git a/slf4j-log4j12/src/main/scala/com/twitter/server/handler/slf4j/log4j12/LoggingHandler.scala b/slf4j-log4j12/src/main/scala/com/twitter/server/handler/slf4j/log4j12/LoggingHandler.scala
@@ -8,9 +8,12 @@ import com.twitter.server.util.HttpUtils._
 import com.twitter.util.Future
 import com.twitter.util.logging.Logging
 import java.net.URLEncoder
-import org.apache.log4j.{Level, LogManager, Logger}
+import org.apache.log4j.Level
+import org.apache.log4j.LogManager
+import org.apache.log4j.Logger
 import scala.collection.JavaConverters._
 
+@deprecated("Users are encouraged to use twitter-server/logback-classic.", "2022-01-12")
 private class LoggingHandler extends com.twitter.server.handler.LoggingHandler with Logging {
 
   /** Implementation name */