This repository has been archived by the owner on Nov 18, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Marko,
Wanted to share a refactoring of TimelineFragment.java so as not to use the deprecated constructor
SimpleCursorAdapter(Context context, int layout, Cursor c, String[] from, int[] to)
but instead use LoaderManager class, mostly following the sample code in the class reference
http://developer.android.com/reference/android/app/LoaderManager.html
Also, for my SDK emulator, I only have Android API Level 15 (ICS 4.0.3), so the project.properties file also got updated to android-15 instead of android-14. I tried to put that change in it's own git branch.
Finally, I'm quite new to git, so hopefully, I've not done something in how I've committed code changes that makes it difficult for you to see and decide whether the refactoring is useful... I've purposely left in commented out prior code to make it a bit easier for you to see what was there previously.
Cheers,
-ChongLim Kim