Skip to content
This repository has been archived by the owner on Nov 1, 2021. It is now read-only.

Real optim state hidden because not passed in #175

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

reneschaub
Copy link

@reneschaub reneschaub commented Aug 29, 2017

No description provided.

@reneschaub
Copy link
Author

reneschaub commented Aug 29, 2017

The test job needs to be modified because the API of optim changed. I wasn't going to leave the misnamed state to stand for 'config' and a new 'config' to be the state.
Or do I have to fix the tests now?

@reneschaub
Copy link
Author

There is some problem with the github build environment. I tested the Lua5.2 version and it tests just fine without errors. I have gcc 4.8, while travis build uses old 4.6, maybe that's the problem. In any case, it is not my checkin but the build just fails now, because the 'LessThan' test gives the wrong gradient.

@CLAassistant
Copy link

CLAassistant commented Jul 18, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Rene Schaub seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants