feat: add context.Context support #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
natebrennand
force-pushed
the
natebrennand/regenerate-SDK-with-context-methods
branch
from
c7a69c3 to
26adf44
Compare
This was referenced Oct 30, 2022
natebrennand
force-pushed
the
natebrennand/regenerate-SDK-with-context-methods
branch
from
dae465a to
4aa4ba2
Compare
|
Need to regenerate for new API's added, will update |
natebrennand
force-pushed
the
natebrennand/regenerate-SDK-with-context-methods
branch
from
6c8a605 to
add173a
Compare
childish-sambino
approved these changes
Nov 8, 2022
childish-sambino
pushed a commit
that referenced
this pull request
Nov 9, 2022
This reverts commit 66288bf.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #98
(to be rebased after landing #196)
This PR uses the new alternative base client interfaces,
BaseClientWithCtxandRequestHandlerWithCtx, that allowcontext.Contextobjects to be provided to every API request. This will allow the Twilio SDK to support context cancellations, and for custom HTTP clients to access the context while executing the request.The final commit regenerates the SDK with oai-generator changes in this PR:
twilio/twilio-oai-generator#301
The contributions are split by commit, but I can make this 2 separate PR's if you'd like me to separate the SDK regeneration from the client changes.
Checklist