Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FLEXY-5363 Pass IsPlugin param from CLI to the Create Deployment API #1052

Merged
merged 5 commits into from
Sep 24, 2024

Conversation

phollaa
Copy link
Contributor

@phollaa phollaa commented Sep 23, 2024

FLEXY-5636
This PR adds an optional IsPlugin: true parameter to the deployment API to prevent CLI asset deployment issues caused by the serverless v2 backdoor closure

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.60%. Comparing base (2d98145) to head (3a87794).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1052      +/-   ##
==========================================
- Coverage   90.66%   90.60%   -0.06%     
==========================================
  Files         146      146              
  Lines       14473    14473              
  Branches      982      981       -1     
==========================================
- Hits        13121    13112       -9     
- Misses       1352     1361       +9     
Flag Coverage Δ
90.60% <100.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phollaa phollaa changed the title FLEXY-5363 FLEXY-5363 Pass IsPlugin param from CLI to the Create Deployment API Sep 23, 2024
@phollaa phollaa requested a review from shwet2407 September 23, 2024 13:49
@phollaa phollaa enabled auto-merge (squash) September 24, 2024 13:10
@phollaa phollaa disabled auto-merge September 24, 2024 13:10
@shwet2407 shwet2407 merged commit 9df3847 into main Sep 24, 2024
11 of 15 checks passed
@shwet2407 shwet2407 deleted the FLEXY-5363 branch September 24, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants