allow for blank ip addresses (spf13#316)

twelvelabs · Jun 4, 2021 · d5e0c06 · d5e0c06
1 parent 85dd5c8
commit d5e0c06
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/ip.go b/ip.go
@@ -16,6 +16,9 @@ func newIPValue(val net.IP, p *net.IP) *ipValue {
 
 func (i *ipValue) String() string { return net.IP(*i).String() }
 func (i *ipValue) Set(s string) error {
+	if s == "" {
+		return nil
+	}
 	ip := net.ParseIP(strings.TrimSpace(s))
 	if ip == nil {
 		return fmt.Errorf("failed to parse IP: %q", s)

diff --git a/ip_test.go b/ip_test.go
@@ -24,7 +24,7 @@ func TestIP(t *testing.T) {
 		{"1.2.3.4", true, "1.2.3.4"},
 		{"127.0.0.1", true, "127.0.0.1"},
 		{"255.255.255.255", true, "255.255.255.255"},
-		{"", false, ""},
+		{"", true, "0.0.0.0"},
 		{"0", false, ""},
 		{"localhost", false, ""},
 		{"0.0.0", false, ""},