-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nested properties #536
Nested properties #536
Conversation
This should run even faster, avoiding a deeper chain of Shapes references to flatten the object representation. Also, you ensure that it isn't any side effects over the end values Check https://v8.dev/blog/cost-of-javascript-2019#json for more information.
…asier (less conflict)
c99bf8d
to
e7810e0
Compare
* master: (22 commits) update dist improve state reset when stopping and starting a tween (fixes #512 where yoyo wouldn't restart properly) move value-swapping code for repeated tweens to a function (it will be re-used in an upcoming change) consolidate duplicate handling of relative values update dist files ignore VS Code's config folder small refactor to prevent update from doing anything when a tween has finished, yet still allow tweens to go back in time fix lint error rename _isFinished to _isComplete to match other wording add one more test for relative array values add editorconfig to settings editors can be consistently unique (because we use tabs so people can set their own tab width) add tests for .to() with relative array values, and implement it add unit tests for yoyo with relative values update yoyo example to test yoyo with relative values Revert "Remove stopChainedTweens test because it didn't test stopChainedTweens." delete Travis CI stuff, we now have free GitHub actions, easier to manage right here in the repo add GitHub Actions config for automated testing fixed issue with not stopping chained tweens when the head chain is not playing. Also works with cyclic chains. bug-fix: update function still be called after end(); fixes #284; add tests for tweening to array ...
@Malows I merged all the latest from master, fixed conflicts. The complex-object tests are passing, but for some reason the I changed over to using Also there are no tests for If you have any ideas, please feel free to open a PR onto this branch. |
Alright, tests are passing (the error was with #320 which I merged yesterday, and this PR was not yet handling that case). Things to do:
|
I think I'll just merge this. As tests are passing, nothing previous is broken, we just need to verify the repeat/yoyo functionality next. This way any upcoming PRs have to keep the tests working (better than having to merge conflicts later). |
closes #260