Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested properties #536

Merged
merged 11 commits into from
May 31, 2020
Merged

Nested properties #536

merged 11 commits into from
May 31, 2020

Conversation

trusktr
Copy link
Member

@trusktr trusktr commented May 31, 2020

closes #260

* master: (22 commits)
  update dist
  improve state reset when stopping and starting a tween (fixes #512 where yoyo wouldn't restart properly)
  move value-swapping code for repeated tweens to a function (it will be re-used in an upcoming change)
  consolidate duplicate handling of relative values
  update dist files
  ignore VS Code's config folder
  small refactor to prevent update from doing anything when a tween has finished, yet still allow tweens to go back in time
  fix lint error
  rename _isFinished to _isComplete to match other wording
  add one more test for relative array values
  add editorconfig to settings editors can be consistently unique (because we use tabs so people can set their own tab width)
  add tests for .to() with relative array values, and implement it
  add unit tests for yoyo with relative values
  update yoyo example to test yoyo with relative values
  Revert "Remove stopChainedTweens test because it didn't test stopChainedTweens."
  delete Travis CI stuff, we now have free GitHub actions, easier to manage right here in the repo
  add GitHub Actions config for automated testing
  fixed issue with not stopping chained tweens when the head chain is not playing. Also works with cyclic chains.
  bug-fix: update function still be called after end();
  fixes #284; add tests for tweening to array
  ...
@trusktr
Copy link
Member Author

trusktr commented May 31, 2020

@Malows I merged all the latest from master, fixed conflicts. The complex-object tests are passing, but for some reason the yoyo works with arrays test isn't passing.

I changed over to using for (var prop in foo) instead of Object.create (instead of JSON.parse). because the Object.create wasn't working when it came to some one of the fixes involving yoyo.

Also there are no tests for repeat and yoyo with regards to complex objects yet.

If you have any ideas, please feel free to open a PR onto this branch.

@trusktr
Copy link
Member Author

trusktr commented May 31, 2020

Alright, tests are passing (the error was with #320 which I merged yesterday, and this PR was not yet handling that case).

Things to do:

  • tests for nested values with repeat
  • tests for nested values with yoyo
  • possibly clean up some logic (conditionals can be simplified, but moving anything around has high chance of exploding, not specifically with regards to nested values but with all that's been compounded over time)

@trusktr
Copy link
Member Author

trusktr commented May 31, 2020

I think I'll just merge this. As tests are passing, nothing previous is broken, we just need to verify the repeat/yoyo functionality next. This way any upcoming PRs have to keep the tests working (better than having to merge conflicts later).

@trusktr trusktr merged commit b505b9a into master May 31, 2020
@trusktr trusktr deleted the nested-properties branch May 31, 2020 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support complex tweens
2 participants