Call bash wrapper on Windows #96
Merged
+47
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove powershell wrapper script (it was not equivalent to the bash script)
There might be no startup options and no command.
stardoc version 0.7.2 is not compatible with older Bazel versions. Note, CI passed but that was because no tests were actually run. This reverts commit 5fba4ed.
avdv
force-pushed
the
cb/remove-ps1-wrapper
branch
from
36e7068 to
414028a
Compare
avdv
force-pushed
the
cb/remove-ps1-wrapper
branch
from
414028a to
04b21e1
Compare
avdv
commented
Dec 6, 2024
| "rules_sh_tests/$(rootpath @rules_sh_import_test_create_shim_test_shim//:shimmed.exe)", | ||
| "rules_sh_tests/$(rootpath @rules_sh_import_test_create_shim_test_shim//:shimmed.shim)", | ||
| "rules_sh_tests/$(rootpath @rules_sh_import_test_create_shim_test_shim//prefix:another.exe)", | ||
| "rules_sh_tests/$(rootpath @rules_sh_import_test_create_shim_test_shim//prefix:another.shim)", |
There was a problem hiding this comment.
Not sure why rootpath was used here in the first place, rlocationpath seems to be a perfect fit. 🤔
Bazel 8 has been released!
Bazel 8 uses the plus sign instead of tilde in repo names now (the `--incompatible_use_plus_in_repo_names` flag is a no-op). That causes the `rlocation` lookup for the arguments of the `@rules_sh_tests//import:create_shim_test` to fail and just return empty results. ``` comm: '': No such file or directory Expected files to be equal, but they are different: '' and ''. ```
This disables automatic POSIX-to-Windows path conversion (/ -> c:\some\path, // -> /). See https://github.com/git-for-windows/build-extra/blob/main/ReleaseNotes.md#known-issues
avdv
force-pushed
the
cb/remove-ps1-wrapper
branch
from
04b21e1 to
c703396
Compare
It used the latest Bazel version by default and failed, see cgrindel/gha_join_jobs#67
avdv
force-pushed
the
cb/remove-ps1-wrapper
branch
from
02206e9 to
1636949
Compare
malt3
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rlocationpathinstead ofrootpathfor Bazel 8 compatibility