vendor large parts of @bazel_tools//tools/cpp #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malt3
force-pushed
the
mp/cc_toolchain_vendoring
branch
3 times, most recently
from
bda7344
to
c3d4c63
Compare
…e//private/cc_toolchain Most of @bazel_tools//tools/cpp was removed from @bazel_tools and moved into a private package in rules_cc in Bazel 8.
This is only available in Bazel 8 and later. See bazelbuild/bazel#9e913fbfa2e3930742fc30dfb60ac5e2694c70cf
This is only available in Bazel 7 and later. See bazelbuild/bazel#b272cef7d4b2d1be4e3f82b737c3c14d5e768aea
malt3
force-pushed
the
mp/cc_toolchain_vendoring
branch
from
c3d4c63
to
44b2669
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of @bazel_tools//tools/cpp was removed from @bazel_tools and moved into a private package in rules_cc in Bazel 8.
It looks like some parameters of
cc_toolchain_configwhere added over the years and are not available in all versions of Bazel.We might need to do some clever version checks when selecting a
BUILD.tplor do some other tricks.Known problematic (see upstream issue):
conly_flagsadded in Bazel 7extra_flags_per_featureadded in Bazel 8Fixes #612