almost all of @bazel_tools//tools/cpp may not exist for [email protected]

[kczulko]

Hello,

I've just received an email from bazelbuild/bazel-central-registry saying that the module I maintain contains errors for [email protected]. The build output says that this import may not exist.

Build run: https://buildkite.com/bazel/bcr-bazel-compatibility-test/builds/72#019367bc-a445-4f6b-8c2b-0413f2287689

Error message:

(09:32:44) ERROR: Traceback (most recent call last):
	File "/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/5d027fa2b9037dc8b327099b176cebb0/external/rules_nixpkgs_core+/util.bzl", line 1, column 55, in <toplevel>
		load("@bazel_tools//tools/cpp:lib_cc_configure.bzl", "get_cpu_value")
Error: file '@bazel_tools//tools/cpp:lib_cc_configure.bzl' does not contain symbol 'get_cpu_value'
(09:32:44) ERROR: Analysis of target '//:spec' failed; build aborted: Error loading '@@rules_nixpkgs_core+//extensions:package.bzl' for module extensions, requested by /var/lib/buildkite-agent/builds/bk-docker-2fzt/bazel-org-repo-root/output/rules_elm-1.0.1/examples/elm-test/MODULE.bazel:105:24: at /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/5d027fa2b9037dc8b327099b176cebb0/external/rules_nixpkgs_core+/extensions/package.bzl:6:6: at /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/5d027fa2b9037dc8b327099b176cebb0/external/rules_nixpkgs_core+/nixpkgs.bzl:36:5: initialization of module 'util.bzl' failed: at /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/5d027fa2b9037dc8b327099b176cebb0/external/rules_nixpkgs_core+/extensions/package.bzl:6:6: at /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/5d027fa2b9037dc8b327099b176cebb0/external/rules_nixpkgs_core+/nixpkgs.bzl:36:5: initialization of module 'util.bzl' failed

[malt3]

Thank you for reporting this bug! It looks like it might be easy enough to fix, since this symbol is now provided by rules_cc.
If you feel comfortable doing so, feel free to open a PR or I'll try to get to it soon.

EDIT: the implementation I linked to is private, so depending on it is probably a bad idea.
@avdv suggested vendoring the macro instead.

[kczulko]

Hi @malt3

Sure, I may give it a try in my spare time. Thx for the hints!

Best regards,
Karol

[malt3]

I noticed that most of that package was deleted.

Here is a list of components I will migrate:

• many symbols from @bazel_tools//tools/cpp:lib_cc_configure.bzl
• @bazel_tools//tools/cpp:BUILD.tpl
• @bazel_tools//tools/cpp:armeabi_cc_toolchain_config.bzl
• @bazel_tools//tools/cpp:generate_system_module_map.sh
• @bazel_tools//tools/cpp:osx_cc_wrapper.sh.tpl
• @bazel_tools//tools/cpp:linux_cc_wrapper.sh.tpl

We can vendor them from rules_cc.