Update example in haskell-use-cases.rst to rules_oci #2137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rules_docker is not just deprecated, the repository is archived and read only. Change the example in the use cases doc to be a rules_oci example. Missing from the example is build-timestamp stamping. That isn't sufficient reason to not update the example with the current state of rules_docker.
avdv
reviewed
Mar 21, 2024
|
|
||
| *n.b.* Due to the `current inability`_ of Nix to be used on macOS (darwin) for building Docker images, it's currently | ||
| not possible to build Docker images for Haskell binaries as above using ``rules_docker`` and Nixpkgs on macOS. | ||
| not possible to build Docker images for Haskell binaries as above using ``rules_oci`` and Nixpkgs on macOS. |
There was a problem hiding this comment.
Since the referenced nixpgks issue is already resolved, we should re-assess the situation now and probably remove that paragraph.
Not an issue with this PR, though. I have created a new issue to track this: #2138
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rules_docker is not just deprecated, the repository is archived and read only. Change the example in the use cases doc to be a rules_oci example.
Missing from the example is build-timestamp stamping. That isn't sufficient reason to not update the example with the current state of rules_docker.