Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci/parallel.nix: nixfmt #100

Merged
merged 8 commits into from
Nov 17, 2024
Merged

ci/parallel.nix: nixfmt #100

merged 8 commits into from
Nov 17, 2024

Conversation

Mic92
Copy link

@Mic92 Mic92 commented Nov 16, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Mic92
Copy link
Author

Mic92 commented Nov 16, 2024

cc @infinisil

Turns out we don't actually need it
the file was using mixed indentation (2 vs 4 spaces)
nproc is only part of coreutils and not present on macOS
this is useful to control how much RAM is used during evaluation
saves us from having to install perl for this script.
@infinisil infinisil merged commit 3364d66 into tweag:gha-eval Nov 17, 2024
14 of 16 checks passed
@Mic92 Mic92 deleted the gha-eval-fixes branch November 20, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants