Skip to content

Commit

Permalink
check-by-name: Pass --base in CI and local running script
Browse files Browse the repository at this point in the history
This enables the ratchet checks for pkgs/by-name, allowing gradual
migrations!
  • Loading branch information
infinisil committed Dec 20, 2023
1 parent 1ad45e5 commit 1968bee
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/check-by-name.yml
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ jobs:
run: pkgs/test/nixpkgs-check-by-name/scripts/fetch-tool.sh "$GITHUB_BASE_REF" result
- name: Running nixpkgs-check-by-name
run: |
if result/bin/nixpkgs-check-by-name .; then
if result/bin/nixpkgs-check-by-name --base "$base" .; then
exit 0
else
exitCode=$?
Expand Down
2 changes: 1 addition & 1 deletion pkgs/test/nixpkgs-check-by-name/scripts/run-local.sh
Original file line number Diff line number Diff line change
Expand Up @@ -63,4 +63,4 @@ echo >&2 -e "\e[34m$(git -C "$tmp/merged" rev-parse HEAD)\e[0m"
cleanup_commands+=('rm "$tmp/tool"')

echo >&2 "Running nixpkgs-check-by-name.."
"$tmp/tool/bin/nixpkgs-check-by-name" "$tmp/merged"
"$tmp/tool/bin/nixpkgs-check-by-name" --base "$tmp/base" "$tmp/merged"

0 comments on commit 1968bee

Please sign in to comment.