Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

himportscan upgrade for GHC 9.6 #60

Closed
wants to merge 8 commits into from

Conversation

wavewave
Copy link
Contributor

@wavewave wavewave commented Dec 21, 2023

this is on top of #59. rebased.

@wavewave wavewave requested a review from avdv as a code owner December 21, 2023 22:03
@avdv
Copy link
Member

avdv commented Dec 22, 2023

@Mergifyio rebase

Copy link
Contributor

mergify bot commented Dec 22, 2023

rebase

❌ Pull request can't be updated with latest base branch changes

Mergify needs the author permission to update the base branch of the pull request.
@MercuryTechnologies needs to authorize modification on its head branch.

@avdv
Copy link
Member

avdv commented Dec 22, 2023

Thank you! Could you also add an entry to the CircleCI job matrix for GHC 9.6 please?

@avdv
Copy link
Member

avdv commented Dec 22, 2023

@wavewave Oh, you also need to add a stack config for 9.6.2. And a lock file for it. Do you know how or should I add this?

@wavewave
Copy link
Contributor Author

Ah. thanks. Just saw your message here. actually, I don't know how to add that snapshot-*.json file. Could you inform me the command? thanks!

@wavewave
Copy link
Contributor Author

now i read rules_haskell documentation and seems like

bazel run @stackage-unpinned//:pin

was the command to generate. :-)

@wavewave
Copy link
Contributor Author

Ok. the missing snapshot file problem got solved but now I have this.. 🤔

ERROR: /home/runner/.cache/bazel/_bazel_runner/2f1e0776f91a8e59682a44ab965a403c/external/stackage/BUILD.bazel:623:26: in haskell_toolchain_library rule @stackage//:template-haskell: 
Traceback (most recent call last):
	File "/home/runner/.cache/bazel/_bazel_runner/2f1e0776f91a8e59682a44ab965a403c/external/rules_haskell/haskell/private/haskell_impl.bzl", line 805, column 13, in haskell_toolchain_library_impl
		fail(
Error in fail: 
template-haskell is not a toolchain library.
Check that it ships with your version of GHC.
The following toolchain libraries are available:
{}

@avdv
Copy link
Member

avdv commented Dec 23, 2023

Ok. the missing snapshot file problem got solved but now I have this.. 🤔

ERROR: /home/runner/.cache/bazel/_bazel_runner/2f1e0776f91a8e59682a44ab965a403c/external/stackage/BUILD.bazel:623:26: in haskell_toolchain_library rule @stackage//:template-haskell: 
Traceback (most recent call last):
	File "/home/runner/.cache/bazel/_bazel_runner/2f1e0776f91a8e59682a44ab965a403c/external/rules_haskell/haskell/private/haskell_impl.bzl", line 805, column 13, in haskell_toolchain_library_impl
		fail(
Error in fail: 
template-haskell is not a toolchain library.
Check that it ships with your version of GHC.
The following toolchain libraries are available:
{}

This is tweag/rules_haskell#1920 which has been fixed in rules_haskell 0.18.

@wavewave
Copy link
Contributor Author

Thanks! updated rules_haskell to 0.18.

@wavewave
Copy link
Contributor Author

Certainly Cabal specified in the snapshot (tweag/cabal 4f8c4ab) is not compatible with GHC 9.6. I am not familiar with the modification needed (first of all, why should we use a custom version of Cabal?). Would you check whether there is a working version (or whether needed for a special Cabal)? BTW, on my project, it was working with stock Cabal on GHC 9.6.

@avdv
Copy link
Member

avdv commented Jan 2, 2024

Certainly Cabal specified in the snapshot (tweag/cabal 4f8c4ab) is not compatible with GHC 9.6. I am not familiar with the modification needed (first of all, why should we use a custom version of Cabal?). Would you check whether there is a working version (or whether needed for a special Cabal)? BTW, on my project, it was working with stock Cabal on GHC 9.6.

This is related to a problem in Cabal (see tweag/rules_haskell#1832) which has been fixed in Cabal 3.10.1. GHC >= 9.6 includes a recent enough version of Cabal so we don't need the workaround anymore.

@avdv avdv closed this in #64 Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants