Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for GHC 9.4 #56

Merged
merged 5 commits into from
Dec 6, 2023
Merged

Add support for GHC 9.4 #56

merged 5 commits into from
Dec 6, 2023

Conversation

avdv
Copy link
Member

@avdv avdv commented Dec 5, 2023 •
edited
Loading

Fixes #55

@avdv avdv marked this pull request as ready for review December 5, 2023 20:02
avdv
avdv commented Dec 6, 2023
View reviewed changes
himportscan/src/HImportScan/GHC9_4.hs
@@ -0,0 +1,102 @@
{-#LANGUAGE CPP #-}

#if __GLASGOW_HASKELL__ >= 904
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this uses >= now and it might also work with later GHC versions, in case the API did not change.

@avdv avdv requested a review from aherrmann December 6, 2023 08:43
aherrmann
aherrmann approved these changes Dec 6, 2023
View reviewed changes
Copy link
Member

@aherrmann aherrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@avdv avdv added the merge-queue merge on green CI label Dec 6, 2023
@mergify mergify bot merged commit 52396b6 into main Dec 6, 2023
8 checks passed
@mergify mergify bot deleted the cb/ghc-9.4.5 branch December 6, 2023 09:08
@mergify mergify bot removed the merge-queue merge on green CI label Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aherrmann aherrmann aherrmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support GHC 9.4.x
2 participants
@avdv @aherrmann