Add packaging tests on windows

tvallin · Nov 13, 2024 · d6341ee · d6341ee
1 parent 0b5c045
commit d6341ee
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 2 deletions.
diff --git a/.github/workflows/validate.yml b/.github/workflows/validate.yml
@@ -315,12 +315,12 @@ jobs:
     timeout-minutes: 30
     strategy:
       matrix:
-        os: [ ubuntu-20.04, macos-14 ]
+        os: [ ubuntu-20.04, macos-14, windows-2022 ]
         packaging: [ jar, jlink ]
         include:
           - { os: ubuntu-20.04, platform: linux }
           - { os: macos-14, platform: macos }
-#          - { os: windows-2022, platform: windows }
+          - { os: windows-2022, platform: windows }
     runs-on: ${{ matrix.os }}
     name: tests/packaging-${{ matrix.packaging }}-${{ matrix.platform }}
     steps:

diff --git a/...inject/src/test/java/io/helidon/tests/integration/packaging/inject/InjectJlinkTestIT.java b/...inject/src/test/java/io/helidon/tests/integration/packaging/inject/InjectJlinkTestIT.java
@@ -18,6 +18,8 @@
 import io.helidon.tests.integration.harness.ProcessRunner.ExecMode;
 
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.condition.DisabledOnOs;
+import org.junit.jupiter.api.condition.OS;
 
 class InjectJlinkTestIT extends InjectPackagingTestIT {
 
@@ -27,11 +29,13 @@ ExecMode execMode() {
     }
 
     @Test
+    @DisabledOnOs(value = OS.WINDOWS, disabledReason = "application is not a valid Win32 application")
     void testExitOnStarted() {
         doTestExitOnStarted();
     }
 
     @Test
+    @DisabledOnOs(value = OS.WINDOWS, disabledReason = "application is not a valid Win32 application")
     void testWebClientService() {
         doTestWebClientService();
     }

diff --git a/...ckaging/mp-1/src/test/java/io/helidon/tests/integration/packaging/mp1/Mp1JlinkTestIT.java b/...ckaging/mp-1/src/test/java/io/helidon/tests/integration/packaging/mp1/Mp1JlinkTestIT.java
@@ -18,6 +18,8 @@
 import io.helidon.tests.integration.harness.ProcessRunner.ExecMode;
 
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.condition.DisabledOnOs;
+import org.junit.jupiter.api.condition.OS;
 
 class Mp1JlinkTestIT extends Mp1PackagingTestIT {
 
@@ -27,6 +29,7 @@ ExecMode execMode() {
     }
 
     @Test
+    @DisabledOnOs(value = OS.WINDOWS, disabledReason = "application is not a valid Win32 application")
     void testApp() {
         doTestApp();
     }

diff --git a/...ckaging/mp-3/src/test/java/io/helidon/tests/integration/packaging/mp3/Mp3JlinkTestIT.java b/...ckaging/mp-3/src/test/java/io/helidon/tests/integration/packaging/mp3/Mp3JlinkTestIT.java
@@ -18,6 +18,8 @@
 import io.helidon.tests.integration.harness.ProcessRunner.ExecMode;
 
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.condition.DisabledOnOs;
+import org.junit.jupiter.api.condition.OS;
 
 class Mp3JlinkTestIT extends Mp3PackagingTestIT {
 
@@ -27,11 +29,13 @@ ExecMode execMode() {
     }
 
     @Test
+    @DisabledOnOs(value = OS.WINDOWS, disabledReason = "application is not a valid Win32 application")
     void testExitOnStarted() {
         doTestExitOnStarted();
     }
 
     @Test
+    @DisabledOnOs(value = OS.WINDOWS, disabledReason = "application is not a valid Win32 application")
     void testGreetResource() {
         doTestGreetResource();
     }

diff --git a/...ckaging/se-1/src/test/java/io/helidon/tests/integration/packaging/se1/Se1JlinkTestIT.java b/...ckaging/se-1/src/test/java/io/helidon/tests/integration/packaging/se1/Se1JlinkTestIT.java
@@ -18,6 +18,8 @@
 import io.helidon.tests.integration.harness.ProcessRunner.ExecMode;
 
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.condition.DisabledOnOs;
+import org.junit.jupiter.api.condition.OS;
 
 class Se1JlinkTestIT extends Se1PackagingTestIT {
 
@@ -27,11 +29,13 @@ ExecMode execMode() {
     }
 
     @Test
+    @DisabledOnOs(value = OS.WINDOWS, disabledReason = "application is not a valid Win32 application")
     void testExitOnStarted() {
         doTestExitOnStarted();
     }
 
     @Test
+    @DisabledOnOs(value = OS.WINDOWS, disabledReason = "application is not a valid Win32 application")
     void testWebClientService() {
         doTestWebClientService();
     }